runtime/vm/raw_object_snapshot.cc - Issue 2160953002: Add a verification step which iterates over the heap and verifies that all canonical objects are co…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 2160953002: Add a verification step which iterates over the heap and verifies that all canonical objects are co… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address code review comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/raw_object_snapshot.cc

diff --git a/runtime/vm/raw_object_snapshot.cc b/runtime/vm/raw_object_snapshot.cc

index c2448a3274a2b1662aba1ff95b3cbeebeed8ccbc..1166562babeced93a490fc79d02eb990485c3a8a 100644

--- a/runtime/vm/raw_object_snapshot.cc

+++ b/runtime/vm/raw_object_snapshot.cc

@@ -231,7 +231,8 @@ RawType* Type::ReadFrom(SnapshotReader* reader,

Type& type = Type::ZoneHandle(reader->zone(), NEW_OBJECT(Type));

bool is_canonical = RawObject::IsCanonical(tags);

bool defer_canonicalization = is_canonical &&

- (!Snapshot::IsFull(kind) && typeclass_is_in_fullsnapshot);

+ ((kind == Snapshot::kMessage) ||

+ (!Snapshot::IsFull(kind) && typeclass_is_in_fullsnapshot));

reader->AddBackRef(object_id, &type, kIsDeserialized, defer_canonicalization);

// Set all non object fields.

« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/verifier.h » ('j') | no next file with comments »