Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: runtime/vm/verifier.h

Issue 2160953002: Add a verification step which iterates over the heap and verifies that all canonical objects are co… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | runtime/vm/verifier.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_VERIFIER_H_ 5 #ifndef VM_VERIFIER_H_
6 #define VM_VERIFIER_H_ 6 #define VM_VERIFIER_H_
7 7
8 #include "vm/flags.h" 8 #include "vm/flags.h"
9 #include "vm/globals.h" 9 #include "vm/globals.h"
10 #include "vm/handles.h" 10 #include "vm/handles.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 virtual void VisitHandle(uword addr); 74 virtual void VisitHandle(uword addr);
75 75
76 private: 76 private:
77 ObjectPointerVisitor* visitor_; 77 ObjectPointerVisitor* visitor_;
78 78
79 ObjectSet* allocated_set; 79 ObjectSet* allocated_set;
80 80
81 DISALLOW_COPY_AND_ASSIGN(VerifyWeakPointersVisitor); 81 DISALLOW_COPY_AND_ASSIGN(VerifyWeakPointersVisitor);
82 }; 82 };
83 83
84
85 #if defined(DEBUG)
86 class VerifyCanonicalVisitor : public ObjectVisitor {
87 public:
88 explicit VerifyCanonicalVisitor(Thread* thread);
89 virtual void VisitObject(RawObject* obj);
90
91 private:
92 Thread* thread_;
93 Instance& instanceHandle_;
94
95 DISALLOW_COPY_AND_ASSIGN(VerifyCanonicalVisitor);
96 };
97 #endif // defined(DEBUG)
98
84 } // namespace dart 99 } // namespace dart
85 100
86 #endif // VM_VERIFIER_H_ 101 #endif // VM_VERIFIER_H_
OLDNEW
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | runtime/vm/verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698