Remove ast_value_factory_ and usages from scope

Remove ast_value_factory_ and usages from scope

This frees up a field in Scope and untangles scope a little from the parser.

BUG=v8:5209
Committed: https://crrev.com/e8e09ca7252af6dfc428aeaff7e7990e1ff8c1da
Cr-Commit-Position: refs/heads/master@{#37887}

[Toon Verwaest, 2016-07-19 13:50:07]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org, marja@chromium.org

[Toon Verwaest, 2016-07-19 13:50:07]

This CL will probably take a step back when
https://codereview.chromium.org/2158343002/ lands and I'll need to rebase... but
ptal already anyway.

[adamk, 2016-07-19 20:49:43]

lgtm % naming

https://codereview.chromium.org/2160943004/diff/1/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2160943004/diff/1/src/parsing/parser-base.h#n...
src/parsing/parser-base.h:628: Scope* NewScope(Scope* parent, FunctionKind kind)
{
Seems like calling this "NewFunctionScope" would make the call-sites clearer
(and would make it obvious how this function differs from the above).

[Toon Verwaest, 2016-07-20 07:29:22]

Addressed comment

[Toon Verwaest, 2016-07-20 07:32:19]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-07-20 07:32:19]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2160943004/#ps20001
(title: "Rename NewScope(...FunctionKind) to NewFunctionScope")

[commit-bot: I haz the power, 2016-07-20 07:32:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 08:08:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 08:08:47]

Description was changed from

==========
Remove ast_value_factory_ and usages from scope

This frees up a field in Scope and untangles scope a little from the parser.

BUG=v8:5209
==========

to

==========
Remove ast_value_factory_ and usages from scope

This frees up a field in Scope and untangles scope a little from the parser.

BUG=v8:5209

Committed: https://crrev.com/e8e09ca7252af6dfc428aeaff7e7990e1ff8c1da
Cr-Commit-Position: refs/heads/master@{#37887}
==========

[commit-bot: I haz the power, 2016-07-20 08:08:48]

Patchset 2 (id:??) landed as
https://crrev.com/e8e09ca7252af6dfc428aeaff7e7990e1ff8c1da
Cr-Commit-Position: refs/heads/master@{#37887}