Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: src/parsing/parser.h

Issue 2160943004: Remove ast_value_factory_ and usages from scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rename NewScope(...FunctionKind) to NewFunctionScope Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser.h
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
index c221b07cfc5afe79a43738e3b0763bb7d2fff952..cf48f61c636b5e519582fdcd2b3acca47ab089ef 100644
--- a/src/parsing/parser.h
+++ b/src/parsing/parser.h
@@ -545,8 +545,8 @@ class ParserTraits {
ZoneList<Statement*>* body, bool accept_IN,
Type::ExpressionClassifier* classifier, int pos, bool* ok);
- V8_INLINE Scope* NewScope(Scope* parent_scope, ScopeType scope_type,
- FunctionKind kind = kNormalFunction);
+ V8_INLINE Scope* NewScope(Scope* parent_scope, ScopeType scope_type);
+ V8_INLINE Scope* NewFunctionScope(Scope* parent_scope, FunctionKind kind);
V8_INLINE void AddFormalParameter(ParserFormalParameters* parameters,
Expression* pattern,
@@ -1146,12 +1146,13 @@ bool ParserTraits::IsFutureStrictReserved(
return parser_->scanner()->IdentifierIsFutureStrictReserved(identifier);
}
-
-Scope* ParserTraits::NewScope(Scope* parent_scope, ScopeType scope_type,
- FunctionKind kind) {
- return parser_->NewScope(parent_scope, scope_type, kind);
+Scope* ParserTraits::NewScope(Scope* parent_scope, ScopeType scope_type) {
+ return parser_->NewScope(parent_scope, scope_type);
}
+Scope* ParserTraits::NewFunctionScope(Scope* parent_scope, FunctionKind kind) {
+ return parser_->NewFunctionScope(parent_scope, kind);
+}
const AstRawString* ParserTraits::EmptyIdentifierString() {
return parser_->ast_value_factory()->empty_string();
« no previous file with comments | « src/ast/scopes.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698