Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: src/ast/scopes.h

Issue 2160943004: Remove ast_value_factory_ and usages from scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rename NewScope(...FunctionKind) to NewFunctionScope Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index cde826a116192e54fcf1d1af8b2cbb011700b758..397a1dbd05a1dfb4e83f97019e96723b5153ae69 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -90,7 +90,6 @@ class Scope: public ZoneObject {
// Construction
Scope(Zone* zone, Scope* outer_scope, ScopeType scope_type,
- AstValueFactory* value_factory,
FunctionKind function_kind = kNormalFunction);
// Compute top scope and allocate variables. For lazy compilation the top
@@ -99,7 +98,8 @@ class Scope: public ZoneObject {
static bool Analyze(ParseInfo* info);
static Scope* DeserializeScopeChain(Isolate* isolate, Zone* zone,
- Context* context, Scope* script_scope);
+ Context* context, Scope* script_scope,
+ AstValueFactory* ast_value_factory);
// The scope name is only used for printing/debugging.
void SetScopeName(const AstRawString* scope_name) {
@@ -107,6 +107,8 @@ class Scope: public ZoneObject {
}
void Initialize();
+ void DeclareThis(AstValueFactory* ast_value_factory);
+ void DeclareDefaultFunctionVariables(AstValueFactory* ast_value_factory);
// Checks if the block scope is redundant, i.e. it does not contain any
// block scoped declarations. In that case it is removed from the scope
@@ -801,11 +803,11 @@ class Scope: public ZoneObject {
// Construct a scope based on the scope info.
Scope(Zone* zone, Scope* inner_scope, ScopeType type,
- Handle<ScopeInfo> scope_info, AstValueFactory* value_factory);
+ Handle<ScopeInfo> scope_info);
// Construct a catch scope with a binding for the name.
- Scope(Zone* zone, Scope* inner_scope, const AstRawString* catch_variable_name,
- AstValueFactory* value_factory);
+ Scope(Zone* zone, Scope* inner_scope,
+ const AstRawString* catch_variable_name);
void AddInnerScope(Scope* inner_scope) {
if (inner_scope != NULL) {
@@ -828,7 +830,6 @@ class Scope: public ZoneObject {
Handle<ScopeInfo> scope_info,
FunctionKind function_kind = kNormalFunction);
- AstValueFactory* ast_value_factory_;
Zone* zone_;
PendingCompilationErrorHandler pending_error_handler_;
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698