Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py

Issue 2160913003: swarmbucket: fix empty dimension value (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: add swarmbucketbuilders test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/cr-buildbucket/swarming/test/swarming_test.py ('k') | go/src/infra/tools/swarming-transition/cmd/swarmbucketbuilders/testdata/builders.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py
diff --git a/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py b/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py
index d0ddc02ae182058fa9b5eb21f2c8e3e6e46afb67..869a5ea9e96c83d45a37c65a87387c3d33940e84 100755
--- a/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py
+++ b/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py
@@ -26,12 +26,12 @@ class SwarmingCfgTest(testing.AppengineTestCase):
cfg = Swarming(
hostname='chromium-swarm.appspot.com',
common_swarming_tags=['master:master.a'],
- common_dimensions=['cores:8', 'pool:default'],
+ common_dimensions=['cores:8', 'pool:default', 'cpu:x86-64'],
builders=[
Swarming.Builder(
name='release',
swarming_tags=['a:b'],
- dimensions=['os:Linux'],
+ dimensions=['os:Linux', 'cpu:'],
recipe=Swarming.Recipe(
repository='https://x.com',
name='foo',
@@ -83,7 +83,6 @@ class SwarmingCfgTest(testing.AppengineTestCase):
'builder #1: name unspecified',
'builder #1: tag #1: does not have ":": wrong2',
'builder #1: dimension #1: no key',
- 'builder #1: dimension #1: no value',
('builder #1: dimension #2: '
'key "a.b" does not match pattern "^[a-zA-Z\_\-]+$"'),
'builder #1: recipe unspecified',
« no previous file with comments | « appengine/cr-buildbucket/swarming/test/swarming_test.py ('k') | go/src/infra/tools/swarming-transition/cmd/swarmbucketbuilders/testdata/builders.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698