swarmbucket: fix empty dimension value

appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py

 
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from components import config as config_component
 from testing_utils import testing
 
 from proto import project_config_pb2
 from test import config_test
 from swarming import swarmingcfg
 
 
 Swarming = project_config_pb2.Swarming
 
 
 class SwarmingCfgTest(testing.AppengineTestCase):
   def cfg_test(self, cfg, expected_errors):
     ctx = config_component.validation.Context()
     swarmingcfg.validate_cfg(cfg, ctx)
     self.assertEqual(
         map(config_test.errmsg, expected_errors),
         ctx.result().messages)
 
   def test_valid(self):
     cfg = Swarming(
       hostname='chromium-swarm.appspot.com',
       common_swarming_tags=['master:master.a'],
-      common_dimensions=['cores:8', 'pool:default'],
+      common_dimensions=['cores:8', 'pool:default', 'cpu:x86-64'],
       builders=[
         Swarming.Builder(
           name='release',
           swarming_tags=['a:b'],
-          dimensions=['os:Linux'],
+          dimensions=['os:Linux', 'cpu:'],
           recipe=Swarming.Recipe(
             repository='https://x.com',
             name='foo',
             properties=['a:b'],
             properties_j=['x:true'],
           ),
         ),
       ],
     )
     self.cfg_test(cfg, [])
@@ skipping 31 matching lines @@
         ),
       ],
     )
     self.cfg_test(cfg, [
       'hostname unspecified',
       'common tag #1: does not have ":": wrong',
       'common dimension #1: does not have ":"',
       'builder #1: name unspecified',
       'builder #1: tag #1: does not have ":": wrong2',
       'builder #1: dimension #1: no key',
-      'builder #1: dimension #1: no value',
       ('builder #1: dimension #2: '
        'key "a.b" does not match pattern "^[a-zA-Z\_\-]+$"'),
       'builder #1: recipe unspecified',
       ('builder b2: tag #1: do not specify builder tag; '
        'it is added by swarmbucket automatically'),
       'builder b2: dimension #2: duplicate key x',
       ('builder b2: has no "pool" dimension. '
        'Either define it in the builder or in "common_dimensions"'),
       'builder b2: recipe: name unspecified',
       'builder b2: recipe: repository unspecified',
@@ skipping 36 matching lines @@
             properties=['a'],
         ),
         builders=[
           Swarming.Builder(name='debug'),
         ],
     )
     self.cfg_test(cfg, [
       'common_recipe: properties #1: does not have colon',
       'builder debug: recipe: repository unspecified',
     ])