appengine/cr-buildbucket/swarming/test/swarming_test.py - Issue 2160913003: swarmbucket: fix empty dimension value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cr-buildbucket/swarming/test/swarming_test.py

Issue 2160913003: swarmbucket: fix empty dimension value (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: add swarmbucketbuilders test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/cr-buildbucket/swarming/test/swarming_test.py

diff --git a/appengine/cr-buildbucket/swarming/test/swarming_test.py b/appengine/cr-buildbucket/swarming/test/swarming_test.py

index 8a0dff2001a466350638fea011c1d7cb9fdd970d..8af8fd66b953dcc3dfa5f5f7d4ea4835dbddac75 100755

--- a/appengine/cr-buildbucket/swarming/test/swarming_test.py

+++ b/appengine/cr-buildbucket/swarming/test/swarming_test.py

@@ -40,7 +40,7 @@ class SwarmingTest(testing.AppengineTestCase):

hostname='chromium-swarm.appspot.com',

url_format='https://example.com/{swarming_hostname}/{task_id}',

common_swarming_tags=['commontag:yes'],

- common_dimensions=['cores:8', 'pool:default'],

+ common_dimensions=['cores:8', 'pool:default', 'cpu:x86-64'],

common_recipe=project_config_pb2.Swarming.Recipe(

repository='https://example.com/repo',

name='recipe',

@@ -49,7 +49,7 @@ class SwarmingTest(testing.AppengineTestCase):

project_config_pb2.Swarming.Builder(

name='builder',

swarming_tags=['buildertag:yes'],

- dimensions=['os:Linux', 'pool:Chrome'],

+ dimensions=['os:Linux', 'pool:Chrome', 'cpu:'],

recipe=project_config_pb2.Swarming.Recipe(

properties=['predefined-property:x'],

properties_j=['predefined-property-bool:true'],