Allow user to pause/resume incognito downloads

Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need an isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
Committed: https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5
Cr-Commit-Position: refs/heads/master@{#407640}

[qinmin, 2016-07-18 22:01:22]

Description was changed from

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable field in DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need the isResumable
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

to

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable field in DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need the isResumable
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

[qinmin, 2016-07-18 22:02:54]

Description was changed from

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable field in DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need the isResumable
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

to

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in
DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need the isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

[qinmin, 2016-07-18 22:03:20]

Description was changed from

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in
DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need the isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

to

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in
DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need an isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

[qinmin, 2016-07-18 22:03:29]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2016-07-18 22:03:30]

PTAL

[qinmin, 2016-07-21 17:02:11]

ping

[qinmin, 2016-07-25 17:21:44]

ping, Ted, would you please take a look?

[Ted C, 2016-07-25 17:33:08]

https://codereview.chromium.org/2160063002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
(right):

https://codereview.chromium.org/2160063002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:24:
public final boolean isPublic;  // Whether the download is public (non
incognito).
can we call this isOffTheRecord to be consistent (and invert all the booleans,
same with the EXTRA we are using).  I'd rather have one concept than two inverse
ones

[qinmin, 2016-07-25 19:56:01]

https://codereview.chromium.org/2160063002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java
(right):

https://codereview.chromium.org/2160063002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java:24:
public final boolean isPublic;  // Whether the download is public (non
incognito).
On 2016/07/25 17:33:08, Ted C wrote:
> can we call this isOffTheRecord to be consistent (and invert all the booleans,
> same with the EXTRA we are using).  I'd rather have one concept than two
inverse
> ones

Done. However, doing this will need to inverse the value in the current
SharedPrefs. The new patch bumped the version number to 2 and inverse the value
for old versions

[Ted C, 2016-07-25 20:04:34]

lgtm

https://codereview.chromium.org/2160063002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
(right):

https://codereview.chromium.org/2160063002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java:350:
assertFalse(entry.isPublic);
does this need to get updated?

[qinmin, 2016-07-25 21:10:34]

https://codereview.chromium.org/2160063002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
(right):

https://codereview.chromium.org/2160063002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java:350:
assertFalse(entry.isPublic);
On 2016/07/25 20:04:34, Ted C wrote:
> does this need to get updated?

Done. Also added a test to test that the value will be inverted from earlier
version

[qinmin, 2016-07-25 21:10:40]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-07-25 21:10:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2160063002/#ps40001
(title: "fix tests")

[commit-bot: I haz the power, 2016-07-25 21:11:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 21:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:25:24]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[qinmin, 2016-07-25 21:58:40]

Patchset #3 (id:40001) has been deleted

[qinmin, 2016-07-25 21:58:54]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-07-25 21:58:55]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2160063002/#ps60001
(title: "fix tests")

[commit-bot: I haz the power, 2016-07-25 21:59:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 22:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:57:24]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[qinmin, 2016-07-25 23:11:14]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-07-25 23:11:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2160063002/#ps80001
(title: "fix clang warning")

[commit-bot: I haz the power, 2016-07-25 23:11:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 00:05:24]

Description was changed from

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in
DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need an isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

to

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in
DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need an isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

[commit-bot: I haz the power, 2016-07-26 00:05:25]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-07-26 00:09:13]

Description was changed from

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in
DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need an isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613
==========

to

==========
Allow user to pause/resume incognito downloads

This CL includes the following fixes:
1. When an incognito download is paused, Chrome currently shows a cancel
button on Android.
There is no way for user to resume the download.
However, user can pause and resume incognito download on desktop chrome.
This change fixes the above behavior to allow paused incognito download
to resume.
It also fixes an issue that wrong profile is used when canceling/pausing
incognito downloads.

2.The CL fixes the usage of isResumable(bad naming) field in
DownloadSharedPreferenceEntry.
When a download starts, isResumable is set to !isOffTheRecord.
And this CL renames isResumable to isPublic in
DownloadSharedPreferenceEntry.
The isPublic field allows chrome to determine if a download should fail when
browser is killed.

3. When a download is paused, we still need an isResumable(correct naming)
variable due to the reason of interruption.
So this CL separates download interruption handling from download
pausing in DownloadManagerService.

BUG=627613

Committed: https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5
Cr-Commit-Position: refs/heads/master@{#407640}
==========

[commit-bot: I haz the power, 2016-07-26 00:09:15]

Patchset 4 (id:??) landed as
https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5
Cr-Commit-Position: refs/heads/master@{#407640}