Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

Issue 2160063002: Allow user to pause/resume incognito downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix clang warning Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
index 3d4fe904887f2b9626a7bf8ee45a3d4b04385362..8e52cd058cb2b7ecaef91e6b2363dbf5241e7eac 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
@@ -63,6 +63,7 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {
DOWNLOAD_FAILED,
DOWNLOAD_PROGRESS,
DOWNLOAD_PAUSED,
+ DOWNLOAD_INTERRUPTED,
CANCEL_DOWNLOAD_ID,
CLEAR_PENDING_DOWNLOADS
}
@@ -152,11 +153,16 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {
}
@Override
- public void notifyDownloadPaused(DownloadInfo downloadInfo, boolean isAutoResumable) {
+ public void notifyDownloadPaused(DownloadInfo downloadInfo) {
assertCorrectExpectedCall(MethodID.DOWNLOAD_PAUSED, downloadInfo);
}
@Override
+ public void notifyDownloadInterrupted(DownloadInfo downloadInfo, boolean isAutoResumable) {
+ assertCorrectExpectedCall(MethodID.DOWNLOAD_INTERRUPTED, downloadInfo);
+ }
+
+ @Override
public void notifyDownloadCanceled(String downloadGuid) {
assertCorrectExpectedCall(MethodID.CANCEL_DOWNLOAD_ID, downloadGuid);
}
@@ -443,10 +449,10 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {
DownloadManagerServiceForTest dService = new DownloadManagerServiceForTest(
getTestContext(), notifier, UPDATE_DELAY_FOR_TEST);
DownloadManagerService.disableNetworkListenerForTest();
- DownloadInfo paused =
+ DownloadInfo interrupted =
Builder.fromDownloadInfo(getDownloadInfo()).setIsResumable(true).build();
- notifier.expect(MethodID.DOWNLOAD_PAUSED, paused);
- dService.onDownloadInterrupted(paused, true);
+ notifier.expect(MethodID.DOWNLOAD_INTERRUPTED, interrupted);
+ dService.onDownloadInterrupted(interrupted, true);
notifier.waitTillExpectedCallsComplete();
}
@@ -479,13 +485,13 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {
final DownloadManagerServiceForTest dService = new DownloadManagerServiceForTest(
getTestContext(), notifier, UPDATE_DELAY_FOR_TEST);
DownloadManagerService.disableNetworkListenerForTest();
- DownloadInfo paused =
+ DownloadInfo interrupted =
Builder.fromDownloadInfo(getDownloadInfo()).setIsResumable(true).build();
- notifier.expect(MethodID.DOWNLOAD_PROGRESS, paused)
- .andThen(MethodID.DOWNLOAD_PAUSED, paused);
- dService.onDownloadUpdated(paused);
+ notifier.expect(MethodID.DOWNLOAD_PROGRESS, interrupted)
+ .andThen(MethodID.DOWNLOAD_INTERRUPTED, interrupted);
+ dService.onDownloadUpdated(interrupted);
Thread.sleep(DELAY_BETWEEN_CALLS);
- dService.onDownloadInterrupted(paused, true);
+ dService.onDownloadInterrupted(interrupted, true);
notifier.waitTillExpectedCallsComplete();
int resumableIdCount = dService.mAutoResumableDownloadIds.size();
dService.onConnectionTypeChanged(ConnectionType.CONNECTION_WIFI);
@@ -506,13 +512,13 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {
final DownloadManagerServiceForTest dService = new DownloadManagerServiceForTest(
getTestContext(), notifier, UPDATE_DELAY_FOR_TEST);
DownloadManagerService.disableNetworkListenerForTest();
- DownloadInfo paused =
+ DownloadInfo interrupted =
Builder.fromDownloadInfo(getDownloadInfo()).setIsResumable(true).build();
- notifier.expect(MethodID.DOWNLOAD_PROGRESS, paused)
- .andThen(MethodID.DOWNLOAD_PAUSED, paused);
- dService.onDownloadUpdated(paused);
+ notifier.expect(MethodID.DOWNLOAD_PROGRESS, interrupted)
+ .andThen(MethodID.DOWNLOAD_INTERRUPTED, interrupted);
+ dService.onDownloadUpdated(interrupted);
Thread.sleep(DELAY_BETWEEN_CALLS);
- dService.onDownloadInterrupted(paused, true);
+ dService.onDownloadInterrupted(interrupted, true);
notifier.waitTillExpectedCallsComplete();
DownloadManagerService.setIsNetworkMeteredForTest(true);
int resumableIdCount = dService.mAutoResumableDownloadIds.size();

Powered by Google App Engine
This is Rietveld 408576698