Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2160003003: Fix layering violations in WebFrameWidget. (Closed)

Created:
4 years, 5 months ago by dcheng
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dcheng, dglazkov+blink, EhsanK, jam, jochen+watch_chromium.org, kinuko+watch, lfg, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layering violations in WebFrameWidget. There are currently Blink-internal interfaces exposed on the public WebFrameWidget interface. Move these to an internal interface: once WebWidget is properly separated from WebView, WebViewFrameWidget will be removed and WebFrameWidgetImpl and WebFrameWidgetBase can be merged. BUG=419087 Committed: https://crrev.com/804a6ba854e3c7cbe182177ad45988b02f832a9c Cr-Commit-Position: refs/heads/master@{#406254}

Patch Set 1 #

Patch Set 2 : Add missing file #

Patch Set 3 : Fix more compiles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -48 lines) Patch
M components/test_runner/test_runner_for_specific_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/web/WebFrameWidgetBase.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 5 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameWidget.h View 2 chunks +0 lines, -22 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
dcheng
4 years, 5 months ago (2016-07-19 07:12:14 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-19 12:31:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2160003003/40001
4 years, 5 months ago (2016-07-19 12:42:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-19 12:46:16 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 12:46:19 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/804a6ba854e3c7cbe182177ad45988b02f832a9c Cr-Commit-Position: refs/heads/master@{#406254}
4 years, 5 months ago (2016-07-19 12:48:12 UTC) #18
haraken
4 years, 5 months ago (2016-07-19 19:58:42 UTC) #19
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698