Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1464)

Unified Diff: third_party/WebKit/public/web/WebFrameWidget.h

Issue 2160003003: Fix layering violations in WebFrameWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix more compiles Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/web.gypi ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebFrameWidget.h
diff --git a/third_party/WebKit/public/web/WebFrameWidget.h b/third_party/WebKit/public/web/WebFrameWidget.h
index e086eb328544740ea233392f7c5706a38f813cc3..6db89b5001187e04dd961a26ea619899ff3cc86a 100644
--- a/third_party/WebKit/public/web/WebFrameWidget.h
+++ b/third_party/WebKit/public/web/WebFrameWidget.h
@@ -37,9 +37,6 @@
namespace blink {
-class CompositorAnimationTimeline;
-class CompositorProxyClient;
-class GraphicsLayer;
class WebLocalFrame;
class WebView;
class WebWidgetClient;
@@ -72,25 +69,6 @@ public:
// persists across subsequent navigations. Defaults to white prior to the
// first call to this method.
virtual void setBaseBackgroundColor(WebColor) = 0;
-
-
- // Blink internal methods --------------------------------------------------
- // TODO(dcheng): Temporary: there should only be one WebFrameWidget
- // implementation but the Blink API is currently in a transition state.
- // See https://goo.gl/7yVrnb. These methods should only be used inside
- // blink.
- virtual bool forSubframe() const { return true; }
- virtual void scheduleAnimation() = 0;
- virtual CompositorProxyClient* createCompositorProxyClient() = 0;
- virtual WebWidgetClient* client() const = 0;
-
- // Sets the root graphics layer. |GraphicsLayer| can be null when detaching
- // the root layer.
- virtual void setRootGraphicsLayer(GraphicsLayer*) = 0;
-
- // Attaches/detaches a CompositorAnimationTimeline to the layer tree.
- virtual void attachCompositorAnimationTimeline(CompositorAnimationTimeline*) = 0;
- virtual void detachCompositorAnimationTimeline(CompositorAnimationTimeline*) = 0;
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/web/web.gypi ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698