Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: third_party/WebKit/Source/web/WebViewFrameWidget.h

Issue 2160003003: Fix layering violations in WebFrameWidget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix more compiles Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewFrameWidget.h
diff --git a/third_party/WebKit/Source/web/WebViewFrameWidget.h b/third_party/WebKit/Source/web/WebViewFrameWidget.h
index 8f39239622bc802b245388d1a51dc7f3ec1ae0a0..7a7a9395deca8b21775a72c4a78028bdf2a49d3f 100644
--- a/third_party/WebKit/Source/web/WebViewFrameWidget.h
+++ b/third_party/WebKit/Source/web/WebViewFrameWidget.h
@@ -6,7 +6,7 @@
#define WebViewFrameWidget_h
#include "platform/heap/Handle.h"
-#include "public/web/WebFrameWidget.h"
+#include "web/WebFrameWidgetBase.h"
#include "wtf/Noncopyable.h"
#include "wtf/RefPtr.h"
@@ -31,7 +31,7 @@ class WebWidgetClient;
// into one class.
// A more detailed writeup of this transition can be read at
// https://goo.gl/7yVrnb.
-class WebViewFrameWidget : public WebFrameWidget {
+class WebViewFrameWidget : public WebFrameWidgetBase {
WTF_MAKE_NONCOPYABLE(WebViewFrameWidget);
public:
explicit WebViewFrameWidget(WebWidgetClient*, WebViewImpl&, WebLocalFrameImpl&);
@@ -92,7 +92,9 @@ public:
bool isTransparent() const override;
void setIsTransparent(bool) override;
void setBaseBackgroundColor(WebColor) override;
- bool forSubframe() const { return false; }
+
+ // WebFrameWidgetBase overrides:
+ bool forSubframe() const override { return false; }
void scheduleAnimation() override;
CompositorProxyClient* createCompositorProxyClient() override;
void setRootGraphicsLayer(GraphicsLayer*) override;
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698