Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2159833002: Revert of Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (Closed)

Created:
4 years, 5 months ago by Evan Stade
Modified:
4 years, 5 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, dgozman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (patchset #8 id:140001 of https://codereview.chromium.org/2062353002/ ) Reason for revert: caused regression: crbug.com/628970 Original issue's description: > Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND > > This fixes issues where the ntp background image was > interrupted underneath the detached bookmark bar. > > Also the ntp_background color is now forced to be opaque > even if a none opaque alpha value is provided from the > theme. This prevent issues with subpixel AA which does not > work on none opaque background. (and to avoid falling back > to grayscale AA) > > Also see crbug.com/618278 > > BUG=618335 > > R=estade@chromium.org, pkasting@chromium.org > > Committed: https://crrev.com/bb4e97590966ba4138b759b8a6450e526a24fa27 > Cr-Commit-Position: refs/heads/master@{#405725} TBR=pkasting@chromium.org,j.isorce@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618335 Committed: https://crrev.com/88c375837d0f16c412839bb6dd1326312d607bb8 Cr-Commit-Position: refs/heads/master@{#406118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -19 lines) Patch
M chrome/browser/themes/browser_theme_pack.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/themes/theme_properties.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/themes/theme_properties.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/chrome_style.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Evan Stade
Created Revert of Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND
4 years, 5 months ago (2016-07-18 16:55:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159833002/1
4 years, 5 months ago (2016-07-18 16:55:48 UTC) #3
Peter Kasting
I don't want to revert this unless we can't find a way to fix the ...
4 years, 5 months ago (2016-07-18 17:20:05 UTC) #5
Peter Kasting
On 2016/07/18 17:20:05, Peter Kasting (OOO til Jul 18) wrote: > I don't want to ...
4 years, 5 months ago (2016-07-18 17:23:34 UTC) #6
Peter Kasting
Proceeding with revert per request on the bug.
4 years, 5 months ago (2016-07-18 22:18:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159833002/1
4 years, 5 months ago (2016-07-18 22:18:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 22:26:08 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 22:28:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88c375837d0f16c412839bb6dd1326312d607bb8
Cr-Commit-Position: refs/heads/master@{#406118}

Powered by Google App Engine
This is Rietveld 408576698