Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: chrome/browser/themes/theme_properties.cc

Issue 2159833002: Revert of Replace CONTROL_BACKGROUND and DETACHED_BOOKMARK_BAR_BACKGROUND by COLOR_NTP_BACKGROUND (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/themes/theme_properties.h ('k') | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/themes/theme_properties.h" 5 #include "chrome/browser/themes/theme_properties.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 const SkColor kDefaultColorToolbar[] = {SkColorSetRGB(0xE6, 0xE6, 0xE6), 60 const SkColor kDefaultColorToolbar[] = {SkColorSetRGB(0xE6, 0xE6, 0xE6),
61 SkColorSetRGB(0xF2, 0xF2, 0xF2)}; 61 SkColorSetRGB(0xF2, 0xF2, 0xF2)};
62 const SkColor kDefaultColorToolbarIncognito[] = { 62 const SkColor kDefaultColorToolbarIncognito[] = {
63 SkColorSetRGB(0xE6, 0xE6, 0xE6), SkColorSetRGB(0x50, 0x50, 0x50)}; 63 SkColorSetRGB(0xE6, 0xE6, 0xE6), SkColorSetRGB(0x50, 0x50, 0x50)};
64 #else 64 #else
65 const SkColor kDefaultColorToolbar[] = {SkColorSetRGB(0xDF, 0xDF, 0xDF), 65 const SkColor kDefaultColorToolbar[] = {SkColorSetRGB(0xDF, 0xDF, 0xDF),
66 SkColorSetRGB(0xF2, 0xF2, 0xF2)}; 66 SkColorSetRGB(0xF2, 0xF2, 0xF2)};
67 const SkColor kDefaultColorToolbarIncognito[] = { 67 const SkColor kDefaultColorToolbarIncognito[] = {
68 SkColorSetRGB(0xDF, 0xDF, 0xDF), SkColorSetRGB(0x50, 0x50, 0x50)}; 68 SkColorSetRGB(0xDF, 0xDF, 0xDF), SkColorSetRGB(0x50, 0x50, 0x50)};
69 #endif // OS_MACOSX 69 #endif // OS_MACOSX
70 const SkColor kDefaultDetachedBookmarkBarBackground[] = {
71 SkColorSetRGB(0xF1, 0xF1, 0xF1), SK_ColorWHITE};
72 const SkColor kDefaultDetachedBookmarkBarBackgroundIncognito[] = {
73 SkColorSetRGB(0xF1, 0xF1, 0xF1), SkColorSetRGB(0x32, 0x32, 0x32)};
74
70 constexpr SkColor kDefaultColorTabText = SK_ColorBLACK; 75 constexpr SkColor kDefaultColorTabText = SK_ColorBLACK;
71 constexpr SkColor kDefaultColorTabTextIncognito[] = {kDefaultColorTabText, 76 constexpr SkColor kDefaultColorTabTextIncognito[] = {kDefaultColorTabText,
72 SK_ColorWHITE}; 77 SK_ColorWHITE};
73 78
74 #if defined(OS_MACOSX) 79 #if defined(OS_MACOSX)
75 constexpr SkColor kDefaultColorBackgroundTabText[] = {SK_ColorBLACK, 80 constexpr SkColor kDefaultColorBackgroundTabText[] = {SK_ColorBLACK,
76 SK_ColorBLACK}; 81 SK_ColorBLACK};
77 constexpr SkColor kDefaultColorBackgroundTabTextIncognito[] = { 82 constexpr SkColor kDefaultColorBackgroundTabTextIncognito[] = {
78 kDefaultColorBackgroundTabText[0], SK_ColorWHITE}; 83 kDefaultColorBackgroundTabText[0], SK_ColorWHITE};
79 #else 84 #else
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 kDefaultTintButtons, {-1, -1, 0.85}}; 122 kDefaultTintButtons, {-1, -1, 0.85}};
118 constexpr color_utils::HSL kDefaultTintFrame = {-1, -1, -1}; 123 constexpr color_utils::HSL kDefaultTintFrame = {-1, -1, -1};
119 constexpr color_utils::HSL kDefaultTintFrameInactive = {-1, -1, 0.75}; 124 constexpr color_utils::HSL kDefaultTintFrameInactive = {-1, -1, 0.75};
120 constexpr color_utils::HSL kDefaultTintFrameIncognito = {-1, 0.2, 0.35}; 125 constexpr color_utils::HSL kDefaultTintFrameIncognito = {-1, 0.2, 0.35};
121 constexpr color_utils::HSL kDefaultTintFrameIncognitoInactive = {-1, 0.3, 0.6}; 126 constexpr color_utils::HSL kDefaultTintFrameIncognitoInactive = {-1, 0.3, 0.6};
122 constexpr color_utils::HSL kDefaultTintBackgroundTab = {-1, -1, 0.75}; 127 constexpr color_utils::HSL kDefaultTintBackgroundTab = {-1, -1, 0.75};
123 128
124 // ---------------------------------------------------------------------------- 129 // ----------------------------------------------------------------------------
125 // Defaults for properties which are not stored in the browser theme pack. 130 // Defaults for properties which are not stored in the browser theme pack.
126 131
132 constexpr SkColor kDefaultColorControlBackground = SK_ColorWHITE;
127 const SkColor kDefaultDetachedBookmarkBarSeparator[] = { 133 const SkColor kDefaultDetachedBookmarkBarSeparator[] = {
128 SkColorSetRGB(0xAA, 0xAA, 0xAB), SkColorSetRGB(0xB6, 0xB4, 0xB6)}; 134 SkColorSetRGB(0xAA, 0xAA, 0xAB), SkColorSetRGB(0xB6, 0xB4, 0xB6)};
129 const SkColor kDefaultDetachedBookmarkBarSeparatorIncognito[] = { 135 const SkColor kDefaultDetachedBookmarkBarSeparatorIncognito[] = {
130 SkColorSetRGB(0xAA, 0xAA, 0xAB), SkColorSetRGB(0x28, 0x28, 0x28)}; 136 SkColorSetRGB(0xAA, 0xAA, 0xAB), SkColorSetRGB(0x28, 0x28, 0x28)};
131 const SkColor kDefaultToolbarTopSeparator = SkColorSetA(SK_ColorBLACK, 0x40); 137 const SkColor kDefaultToolbarTopSeparator = SkColorSetA(SK_ColorBLACK, 0x40);
132 138
133 #if defined(OS_MACOSX) 139 #if defined(OS_MACOSX)
134 const SkColor kDefaultColorFrameVibrancyOverlay[] = { 140 const SkColor kDefaultColorFrameVibrancyOverlay[] = {
135 SkColorSetA(SK_ColorBLACK, 0x19), SkColorSetARGB(0xE6, 0x14, 0x16, 0x18)}; 141 SkColorSetA(SK_ColorBLACK, 0x19), SkColorSetARGB(0xE6, 0x14, 0x16, 0x18)};
136 const SkColor kDefaultColorToolbarInactive[] = { 142 const SkColor kDefaultColorToolbarInactive[] = {
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 case COLOR_NTP_SECTION_TEXT: 354 case COLOR_NTP_SECTION_TEXT:
349 return kDefaultColorNTPSectionText; 355 return kDefaultColorNTPSectionText;
350 case COLOR_NTP_SECTION_LINK: 356 case COLOR_NTP_SECTION_LINK:
351 return kDefaultColorNTPSectionLink; 357 return kDefaultColorNTPSectionLink;
352 case COLOR_NTP_SECTION_LINK_UNDERLINE: 358 case COLOR_NTP_SECTION_LINK_UNDERLINE:
353 return TintForUnderline(kDefaultColorNTPSectionLink); 359 return TintForUnderline(kDefaultColorNTPSectionLink);
354 case COLOR_BUTTON_BACKGROUND: 360 case COLOR_BUTTON_BACKGROUND:
355 return kDefaultColorButtonBackground; 361 return kDefaultColorButtonBackground;
356 362
357 // Properties not stored in theme pack. 363 // Properties not stored in theme pack.
364 case COLOR_CONTROL_BACKGROUND:
365 return kDefaultColorControlBackground;
358 case COLOR_BOOKMARK_BAR_INSTRUCTIONS_TEXT: 366 case COLOR_BOOKMARK_BAR_INSTRUCTIONS_TEXT:
359 return otr ? kDefaultColorBookmarkInstructionsTextIncognito[mode] 367 return otr ? kDefaultColorBookmarkInstructionsTextIncognito[mode]
360 : kDefaultColorBookmarkInstructionsText[mode]; 368 : kDefaultColorBookmarkInstructionsText[mode];
361 case COLOR_TOOLBAR_BOTTOM_SEPARATOR: 369 case COLOR_TOOLBAR_BOTTOM_SEPARATOR:
362 case COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR: 370 case COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR:
363 return otr ? kDefaultDetachedBookmarkBarSeparatorIncognito[mode] 371 return otr ? kDefaultDetachedBookmarkBarSeparatorIncognito[mode]
364 : kDefaultDetachedBookmarkBarSeparator[mode]; 372 : kDefaultDetachedBookmarkBarSeparator[mode];
373 case COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND:
374 return otr ? kDefaultDetachedBookmarkBarBackgroundIncognito[mode]
375 : kDefaultDetachedBookmarkBarBackground[mode];
365 case COLOR_TOOLBAR_TOP_SEPARATOR: 376 case COLOR_TOOLBAR_TOP_SEPARATOR:
366 case COLOR_TOOLBAR_TOP_SEPARATOR_INACTIVE: 377 case COLOR_TOOLBAR_TOP_SEPARATOR_INACTIVE:
367 return kDefaultToolbarTopSeparator; 378 return kDefaultToolbarTopSeparator;
368 #if defined(OS_MACOSX) 379 #if defined(OS_MACOSX)
369 case COLOR_FRAME_VIBRANCY_OVERLAY: 380 case COLOR_FRAME_VIBRANCY_OVERLAY:
370 return kDefaultColorFrameVibrancyOverlay[otr]; 381 return kDefaultColorFrameVibrancyOverlay[otr];
371 case COLOR_TOOLBAR_INACTIVE: 382 case COLOR_TOOLBAR_INACTIVE:
372 return otr ? kDefaultColorToolbarInactiveIncognito[mode] 383 return otr ? kDefaultColorToolbarInactiveIncognito[mode]
373 : kDefaultColorToolbarInactive[mode]; 384 : kDefaultColorToolbarInactive[mode];
374 case COLOR_BACKGROUND_TAB_INACTIVE: 385 case COLOR_BACKGROUND_TAB_INACTIVE:
(...skipping 17 matching lines...) Expand all
392 #endif 403 #endif
393 case COLOR_FRAME_INCOGNITO: 404 case COLOR_FRAME_INCOGNITO:
394 case COLOR_FRAME_INCOGNITO_INACTIVE: 405 case COLOR_FRAME_INCOGNITO_INACTIVE:
395 NOTREACHED() << "These values should be queried via their respective " 406 NOTREACHED() << "These values should be queried via their respective "
396 "non-incognito equivalents and an appropriate |otr| " 407 "non-incognito equivalents and an appropriate |otr| "
397 "value."; 408 "value.";
398 default: 409 default:
399 return gfx::kPlaceholderColor; 410 return gfx::kPlaceholderColor;
400 } 411 }
401 } 412 }
OLDNEW
« no previous file with comments | « chrome/browser/themes/theme_properties.h ('k') | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698