Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tools/metrics/actions/actions.xml

Issue 2159813002: Clean up Media_* actions by marking them obsolete and not_user_trigerred. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark obsolete Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/actions.xml
diff --git a/tools/metrics/actions/actions.xml b/tools/metrics/actions/actions.xml
index 0f798ce8a82e96ec926b2a930fc8b7afa9fad359..68daef9fd901bfbeded56c86529c03e158fb4a89 100644
--- a/tools/metrics/actions/actions.xml
+++ b/tools/metrics/actions/actions.xml
@@ -8557,34 +8557,43 @@ should be able to be added at any place in this file.
</description>
</action>
-<action name="Media_Paused">
+<action name="Media_Paused" not_user_triggered="true">
Ilya Sherman 2016/07/25 18:41:58 nit: Seems like the not_user_triggered flag should
mlamouri (slow - plz ping) 2016/07/26 17:29:52 Maybe it's better to mark them properly even if it
Ilya Sherman 2016/07/26 19:17:24 It's not entirely obvious to me that it's "correct
<owner>liberato@chromium.org</owner>
- <description>Media playback was paused.</description>
+ <description>
+ Media playback was paused, either from script or controls.
+ </description>
+ <obsolete>No longer recorded.</obsolete>
</action>
<action name="Media_Play_WithGesture">
<owner>liberato@chromium.org</owner>
<description>A call to play() with a user gesture succeeded.</description>
+ <obsolete>No longer recorded.</obsolete>
</action>
-<action name="Media_Playback_Ended">
+<action name="Media_Playback_Ended" not_user_triggered="true">
<owner>liberato@chromium.org</owner>
<description>Media playback reached the end.</description>
</action>
-<action name="Media_Playback_Mute_Off">
+<action name="Media_Playback_Mute_Off" not_user_triggered="true">
<owner>liberato@chromium.org</owner>
- <description>Mute was turned off.</description>
+ <description>
+ Mute was turned off, either from script or controls.
+ </description>
+ <obsolete>No longer recorded.</obsolete>
</action>
-<action name="Media_Playback_Mute_On">
+<action name="Media_Playback_Mute_On" not_user_triggered="true">
<owner>liberato@chromium.org</owner>
- <description>Mute was turned on.</description>
+ <description>Mute was turned on, either from script or controls.</description>
+ <obsolete>No longer recorded.</obsolete>
</action>
-<action name="Media_Playback_Started">
+<action name="Media_Playback_Started" not_user_triggered="true">
<owner>liberato@chromium.org</owner>
<description>Media playback started due to any cause.</description>
+ <obsolete>No longer recorded.</obsolete>
</action>
<action name="Media_RequestRemotePlayback">
@@ -8592,6 +8601,7 @@ should be able to be added at any place in this file.
<description>
User requested to transfer playback to a remote player, via 'cast' button.
</description>
+ <obsolete>No longer recorded.</obsolete>
</action>
<action name="Media_RequestRemotePlayback_Control">
@@ -8599,16 +8609,21 @@ should be able to be added at any place in this file.
<description>
User requested to control playback of a remote player, such as Chromecast.
</description>
+ <obsolete>No longer recorded.</obsolete>
</action>
-<action name="Media_Seeked">
+<action name="Media_Seeked" not_user_triggered="true">
<owner>liberato@chromium.org</owner>
- <description>Seek to different time completed.</description>
+ <description>Seek originating from script or controls completed.</description>
+ <obsolete>No longer recorded.</obsolete>
</action>
-<action name="Media_SetVolume">
+<action name="Media_SetVolume" not_user_triggered="true">
<owner>liberato@chromium.org</owner>
- <description>Playback volume was changed.</description>
+ <description>
+ Playback volume was changed, either from script or controls.
+ </description>
+ <obsolete>No longer recorded.</obsolete>
</action>
<action name="Menu_Take_Screenshot">
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698