Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2159813002: Clean up Media_* actions by marking them obsolete and not_user_trigerred. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark obsolete Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | tools/metrics/actions/actions.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index bb0fc955d3aeead2b68a348068ff2f76257cad2e..ac9b55438f84d940edf9e06781cf5e5324ff30a2 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -1794,8 +1794,6 @@ void HTMLMediaElement::finishSeek()
scheduleEvent(EventTypeNames::seeked);
setDisplayMode(Video);
-
- Platform::current()->recordAction(UserMetricsAction("Media_Seeked"));
}
HTMLMediaElement::ReadyState HTMLMediaElement::getReadyState() const
@@ -2104,7 +2102,6 @@ Nullable<ExceptionCode> HTMLMediaElement::play()
UserGestureIndicator::utilizeUserGesture();
// We ask the helper to remove the gesture requirement for us, so that
// it can record the reason.
- Platform::current()->recordAction(UserMetricsAction("Media_Play_WithGesture"));
m_autoplayHelper->unlockUserGesture(GesturelessPlaybackEnabledByPlayMethod);
}
@@ -2192,14 +2189,12 @@ void HTMLMediaElement::requestRemotePlayback()
{
DCHECK(m_remoteRoutesAvailable);
webMediaPlayer()->requestRemotePlayback();
- Platform::current()->recordAction(UserMetricsAction("Media_RequestRemotePlayback"));
}
void HTMLMediaElement::requestRemotePlaybackControl()
{
DCHECK(m_remoteRoutesAvailable);
webMediaPlayer()->requestRemotePlaybackControl();
- Platform::current()->recordAction(UserMetricsAction("Media_RequestRemotePlayback_Control"));
}
void HTMLMediaElement::closeMediaSource()
@@ -2265,8 +2260,6 @@ void HTMLMediaElement::setVolume(double vol, ExceptionState& exceptionState)
return;
}
- Platform::current()->recordAction(UserMetricsAction("Media_SetVolume"));
-
m_volume = vol;
updateVolume();
scheduleEvent(EventTypeNames::volumechange);
@@ -2294,11 +2287,6 @@ void HTMLMediaElement::setMuted(bool muted)
updateVolume();
- if (muted)
- Platform::current()->recordAction(UserMetricsAction("Media_Playback_Mute_On"));
- else
- Platform::current()->recordAction(UserMetricsAction("Media_Playback_Mute_Off"));
-
scheduleEvent(EventTypeNames::volumechange);
// If an element autoplayed while muted, it needs to be unlocked to unmute,
@@ -2908,7 +2896,6 @@ void HTMLMediaElement::timeChanged()
}
// Queue a task to fire a simple event named ended at the media element.
scheduleEvent(EventTypeNames::ended);
- Platform::current()->recordAction(UserMetricsAction("Media_Playback_Ended"));
}
}
updatePlayState();
@@ -3134,8 +3121,6 @@ void HTMLMediaElement::updatePlayState()
webMediaPlayer()->setRate(playbackRate());
updateVolume();
webMediaPlayer()->play();
- Platform::current()->recordAction(
- UserMetricsAction("Media_Playback_Started"));
m_autoplayHelper->playbackStarted();
}
@@ -3147,7 +3132,6 @@ void HTMLMediaElement::updatePlayState()
} else { // Should not be playing right now
if (isPlaying) {
webMediaPlayer()->pause();
- Platform::current()->recordAction(UserMetricsAction("Media_Paused"));
m_autoplayHelper->playbackStopped();
}
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | tools/metrics/actions/actions.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698