Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: tools/metrics/actions/actions.xml

Issue 2159813002: Clean up Media_* actions by marking them obsolete and not_user_trigerred. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark obsolete Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <!-- 7 <!--
8 This file is a comprehensive list of Chrome user actions along with the owner 8 This file is a comprehensive list of Chrome user actions along with the owner
9 and description for each user action. A user action should be tied to an actual 9 and description for each user action. A user action should be tied to an actual
10 action taken by a user. It should be logged immediately after a user takes the 10 action taken by a user. It should be logged immediately after a user takes the
(...skipping 8539 matching lines...) Expand 10 before | Expand all | Expand 10 after
8550 </action> 8550 </action>
8551 8551
8552 <action name="MediaRouter_Ui_Navigate_SinkListToSource"> 8552 <action name="MediaRouter_Ui_Navigate_SinkListToSource">
8553 <owner>apacible@chromium.org</owner> 8553 <owner>apacible@chromium.org</owner>
8554 <description> 8554 <description>
8555 User explicitly clicked to navigate from the sink view to the cast mode 8555 User explicitly clicked to navigate from the sink view to the cast mode
8556 view. 8556 view.
8557 </description> 8557 </description>
8558 </action> 8558 </action>
8559 8559
8560 <action name="Media_Paused"> 8560 <action name="Media_Paused" not_user_triggered="true">
Ilya Sherman 2016/07/25 18:41:58 nit: Seems like the not_user_triggered flag should
mlamouri (slow - plz ping) 2016/07/26 17:29:52 Maybe it's better to mark them properly even if it
Ilya Sherman 2016/07/26 19:17:24 It's not entirely obvious to me that it's "correct
8561 <owner>liberato@chromium.org</owner> 8561 <owner>liberato@chromium.org</owner>
8562 <description>Media playback was paused.</description> 8562 <description>
8563 Media playback was paused, either from script or controls.
8564 </description>
8565 <obsolete>No longer recorded.</obsolete>
8563 </action> 8566 </action>
8564 8567
8565 <action name="Media_Play_WithGesture"> 8568 <action name="Media_Play_WithGesture">
8566 <owner>liberato@chromium.org</owner> 8569 <owner>liberato@chromium.org</owner>
8567 <description>A call to play() with a user gesture succeeded.</description> 8570 <description>A call to play() with a user gesture succeeded.</description>
8571 <obsolete>No longer recorded.</obsolete>
8568 </action> 8572 </action>
8569 8573
8570 <action name="Media_Playback_Ended"> 8574 <action name="Media_Playback_Ended" not_user_triggered="true">
8571 <owner>liberato@chromium.org</owner> 8575 <owner>liberato@chromium.org</owner>
8572 <description>Media playback reached the end.</description> 8576 <description>Media playback reached the end.</description>
8573 </action> 8577 </action>
8574 8578
8575 <action name="Media_Playback_Mute_Off"> 8579 <action name="Media_Playback_Mute_Off" not_user_triggered="true">
8576 <owner>liberato@chromium.org</owner> 8580 <owner>liberato@chromium.org</owner>
8577 <description>Mute was turned off.</description> 8581 <description>
8582 Mute was turned off, either from script or controls.
8583 </description>
8584 <obsolete>No longer recorded.</obsolete>
8578 </action> 8585 </action>
8579 8586
8580 <action name="Media_Playback_Mute_On"> 8587 <action name="Media_Playback_Mute_On" not_user_triggered="true">
8581 <owner>liberato@chromium.org</owner> 8588 <owner>liberato@chromium.org</owner>
8582 <description>Mute was turned on.</description> 8589 <description>Mute was turned on, either from script or controls.</description>
8590 <obsolete>No longer recorded.</obsolete>
8583 </action> 8591 </action>
8584 8592
8585 <action name="Media_Playback_Started"> 8593 <action name="Media_Playback_Started" not_user_triggered="true">
8586 <owner>liberato@chromium.org</owner> 8594 <owner>liberato@chromium.org</owner>
8587 <description>Media playback started due to any cause.</description> 8595 <description>Media playback started due to any cause.</description>
8596 <obsolete>No longer recorded.</obsolete>
8588 </action> 8597 </action>
8589 8598
8590 <action name="Media_RequestRemotePlayback"> 8599 <action name="Media_RequestRemotePlayback">
8591 <owner>liberato@chromium.org</owner> 8600 <owner>liberato@chromium.org</owner>
8592 <description> 8601 <description>
8593 User requested to transfer playback to a remote player, via 'cast' button. 8602 User requested to transfer playback to a remote player, via 'cast' button.
8594 </description> 8603 </description>
8604 <obsolete>No longer recorded.</obsolete>
8595 </action> 8605 </action>
8596 8606
8597 <action name="Media_RequestRemotePlayback_Control"> 8607 <action name="Media_RequestRemotePlayback_Control">
8598 <owner>liberato@chromium.org</owner> 8608 <owner>liberato@chromium.org</owner>
8599 <description> 8609 <description>
8600 User requested to control playback of a remote player, such as Chromecast. 8610 User requested to control playback of a remote player, such as Chromecast.
8601 </description> 8611 </description>
8612 <obsolete>No longer recorded.</obsolete>
8602 </action> 8613 </action>
8603 8614
8604 <action name="Media_Seeked"> 8615 <action name="Media_Seeked" not_user_triggered="true">
8605 <owner>liberato@chromium.org</owner> 8616 <owner>liberato@chromium.org</owner>
8606 <description>Seek to different time completed.</description> 8617 <description>Seek originating from script or controls completed.</description>
8618 <obsolete>No longer recorded.</obsolete>
8607 </action> 8619 </action>
8608 8620
8609 <action name="Media_SetVolume"> 8621 <action name="Media_SetVolume" not_user_triggered="true">
8610 <owner>liberato@chromium.org</owner> 8622 <owner>liberato@chromium.org</owner>
8611 <description>Playback volume was changed.</description> 8623 <description>
8624 Playback volume was changed, either from script or controls.
8625 </description>
8626 <obsolete>No longer recorded.</obsolete>
8612 </action> 8627 </action>
8613 8628
8614 <action name="Menu_Take_Screenshot"> 8629 <action name="Menu_Take_Screenshot">
8615 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> 8630 <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
8616 <description>Please enter the description of this user action.</description> 8631 <description>Please enter the description of this user action.</description>
8617 </action> 8632 </action>
8618 8633
8619 <action name="MinButton_Clk"> 8634 <action name="MinButton_Clk">
8620 <owner>Please list the metric's owners. Add more owner tags as needed.</owner> 8635 <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
8621 <description>Please enter the description of this user action.</description> 8636 <description>Please enter the description of this user action.</description>
(...skipping 6634 matching lines...) Expand 10 before | Expand all | Expand 10 after
15256 <action name="webapps.AddShortcut.Manifest"> 15271 <action name="webapps.AddShortcut.Manifest">
15257 <owner>mlamouri@chromium.org</owner> 15272 <owner>mlamouri@chromium.org</owner>
15258 <description> 15273 <description>
15259 Shortcut added to the homescreen with a valid Manifest. This action will be 15274 Shortcut added to the homescreen with a valid Manifest. This action will be
15260 recorded in addition to AppShortcut, AppShortcutApple and Bookmark actions 15275 recorded in addition to AppShortcut, AppShortcutApple and Bookmark actions
15261 to keep a trend of whether the webapp also add meta tags. 15276 to keep a trend of whether the webapp also add meta tags.
15262 </description> 15277 </description>
15263 </action> 15278 </action>
15264 15279
15265 </actions> 15280 </actions>
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698