third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: works Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/SourceLocation.h ('K') | « third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

index 2f161f11bd4103de168f9a3e933f3a6a9005a69d..eb83ba86377d173778495e6646f5a31eca758835 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

@@ -830,7 +830,7 @@ void InspectorNetworkAgent::didScheduleStyleRecalculation(Document* document)

std::unique_ptr<protocol::Network::Initiator> InspectorNetworkAgent::buildInitiatorObject(Document* document, const FetchInitiatorInfo& initiatorInfo)

{

- std::unique_ptr<protocol::Runtime::StackTrace> currentStackTrace = SourceLocation::capture(document)->buildInspectorObject();

+ std::unique_ptr<protocol::Runtime::Exported::StackTrace> currentStackTrace = SourceLocation::capture(document)->buildInspectorObject();

if (currentStackTrace) {

std::unique_ptr<protocol::Network::Initiator> initiatorObject = protocol::Network::Initiator::create()

.setType(protocol::Network::Initiator::TypeEnum::Script).build();

@@ -860,7 +860,7 @@ std::unique_ptr<protocol::Network::Initiator> InspectorNetworkAgent::buildInitia

void InspectorNetworkAgent::didCreateWebSocket(Document* document, unsigned long identifier, const KURL& requestURL, const String&)

{

- std::unique_ptr<protocol::Runtime::StackTrace> currentStackTrace = SourceLocation::capture(document)->buildInspectorObject();

+ std::unique_ptr<protocol::Runtime::Exported::StackTrace> currentStackTrace = SourceLocation::capture(document)->buildInspectorObject();

if (!currentStackTrace) {

frontend()->webSocketCreated(IdentifiersFactory::requestId(identifier), urlWithoutFragment(requestURL).getString());

return;