third_party/WebKit/Source/bindings/core/v8/SourceLocation.h - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: works Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/debugger/domdebugger-getEventListeners.html ('k') | third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

index 69b5af5b46ceb2e49ef49de2d3a03b6e7ff7f723..2b14b015b7669d1368e00b44584179ce66bd6d33 100644

--- a/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

+++ b/third_party/WebKit/Source/bindings/core/v8/SourceLocation.h

@@ -18,8 +18,6 @@ class ExecutionContext;

class TracedValue;

class V8StackTrace;

-namespace protocol { namespace Runtime { class StackTrace; }}

class CORE_EXPORT SourceLocation {

public:

// Zero lineNumber and columnNumber mean unknown. Captures current stack trace.

@@ -55,7 +53,7 @@ public:

String toString() const;

// Could be null when stack trace is unknown.

- std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObject() const;

+ std::unique_ptr<protocol::Runtime::Exported::StackTrace> buildInspectorObject() const;

pfeldman 2016/07/22 18:02:39 Runtime::API::StackTrace

dgozman 2016/07/22 21:21:19 Done.

private:

SourceLocation(const String& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId);