third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp - Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

Issue 2159633002: [DevTools] Generate public versions of protocol classes to be exposed in v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: works Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/SourceLocation.h ('K') | « third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

index 6de98341a747720c5800110443a71d837cd31778..c613c77608fb9d86b68fb5d0f6c77ca180aed970 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp

@@ -86,7 +86,7 @@ void InspectorLogAgent::consoleMessageAdded(ConsoleMessage* message)

.build();

if (!message->location()->url().isEmpty())

entry->setUrl(message->location()->url());

- std::unique_ptr<protocol::Runtime::StackTrace> stackTrace = message->location()->buildInspectorObject();

+ std::unique_ptr<protocol::Runtime::Exported::StackTrace> stackTrace = message->location()->buildInspectorObject();

if (stackTrace)

entry->setStackTrace(std::move(stackTrace));

if (message->location()->lineNumber())