Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp b/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
index c71427c489e723bb3f46ea76391adb257bd43497..cd3e96910dfb2cf1237d84ca2f06f429d5969d6f 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp
@@ -48,7 +48,7 @@ void AudioBasicInspectorHandler::pullInputs(size_t framesToProcess)
AudioNode* AudioBasicInspectorNode::connect(AudioNode* destination, unsigned outputIndex, unsigned inputIndex, ExceptionState& exceptionState)
{
- ASSERT(isMainThread());
+ DCHECK(isMainThread());
AbstractAudioContext::AutoLocker locker(context());
@@ -60,7 +60,7 @@ AudioNode* AudioBasicInspectorNode::connect(AudioNode* destination, unsigned out
void AudioBasicInspectorNode::disconnect(unsigned outputIndex, ExceptionState& exceptionState)
{
- ASSERT(isMainThread());
+ DCHECK(isMainThread());
AbstractAudioContext::AutoLocker locker(context());
@@ -70,10 +70,10 @@ void AudioBasicInspectorNode::disconnect(unsigned outputIndex, ExceptionState& e
void AudioBasicInspectorHandler::checkNumberOfChannelsForInput(AudioNodeInput* input)
{
- ASSERT(context()->isAudioThread());
+ DCHECK(context()->isAudioThread());
ASSERT(context()->isGraphOwner());
- ASSERT(input == &this->input(0));
+ DCHECK(input == &this->input(0));
hongchan 2016/07/20 16:11:19 DCHECK_EQ?
HyungwookLee 2016/07/22 03:30:34 Done.
if (input != &this->input(0))
return;

Powered by Google App Engine
This is Rietveld 408576698