Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Intel Corporation. All rights reserved. 2 * Copyright (C) 2012, Intel Corporation. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 30 matching lines...) Expand all
41 // where the input is simply passed through unprocessed to the output. 41 // where the input is simply passed through unprocessed to the output.
42 // Note: this only applies if the input and output channel counts match. 42 // Note: this only applies if the input and output channel counts match.
43 void AudioBasicInspectorHandler::pullInputs(size_t framesToProcess) 43 void AudioBasicInspectorHandler::pullInputs(size_t framesToProcess)
44 { 44 {
45 // Render input stream - try to render directly into output bus for pass-thr ough processing where process() doesn't need to do anything... 45 // Render input stream - try to render directly into output bus for pass-thr ough processing where process() doesn't need to do anything...
46 input(0).pull(output(0).bus(), framesToProcess); 46 input(0).pull(output(0).bus(), framesToProcess);
47 } 47 }
48 48
49 AudioNode* AudioBasicInspectorNode::connect(AudioNode* destination, unsigned out putIndex, unsigned inputIndex, ExceptionState& exceptionState) 49 AudioNode* AudioBasicInspectorNode::connect(AudioNode* destination, unsigned out putIndex, unsigned inputIndex, ExceptionState& exceptionState)
50 { 50 {
51 ASSERT(isMainThread()); 51 DCHECK(isMainThread());
52 52
53 AbstractAudioContext::AutoLocker locker(context()); 53 AbstractAudioContext::AutoLocker locker(context());
54 54
55 AudioNode::connect(destination, outputIndex, inputIndex, exceptionState); 55 AudioNode::connect(destination, outputIndex, inputIndex, exceptionState);
56 static_cast<AudioBasicInspectorHandler&>(handler()).updatePullStatus(); 56 static_cast<AudioBasicInspectorHandler&>(handler()).updatePullStatus();
57 57
58 return destination; 58 return destination;
59 } 59 }
60 60
61 void AudioBasicInspectorNode::disconnect(unsigned outputIndex, ExceptionState& e xceptionState) 61 void AudioBasicInspectorNode::disconnect(unsigned outputIndex, ExceptionState& e xceptionState)
62 { 62 {
63 ASSERT(isMainThread()); 63 DCHECK(isMainThread());
64 64
65 AbstractAudioContext::AutoLocker locker(context()); 65 AbstractAudioContext::AutoLocker locker(context());
66 66
67 AudioNode::disconnect(outputIndex, exceptionState); 67 AudioNode::disconnect(outputIndex, exceptionState);
68 static_cast<AudioBasicInspectorHandler&>(handler()).updatePullStatus(); 68 static_cast<AudioBasicInspectorHandler&>(handler()).updatePullStatus();
69 } 69 }
70 70
71 void AudioBasicInspectorHandler::checkNumberOfChannelsForInput(AudioNodeInput* i nput) 71 void AudioBasicInspectorHandler::checkNumberOfChannelsForInput(AudioNodeInput* i nput)
72 { 72 {
73 ASSERT(context()->isAudioThread()); 73 DCHECK(context()->isAudioThread());
74 ASSERT(context()->isGraphOwner()); 74 ASSERT(context()->isGraphOwner());
75 75
76 ASSERT(input == &this->input(0)); 76 DCHECK(input == &this->input(0));
hongchan 2016/07/20 16:11:19 DCHECK_EQ?
HyungwookLee 2016/07/22 03:30:34 Done.
77 if (input != &this->input(0)) 77 if (input != &this->input(0))
78 return; 78 return;
79 79
80 unsigned numberOfChannels = input->numberOfChannels(); 80 unsigned numberOfChannels = input->numberOfChannels();
81 81
82 if (numberOfChannels != output(0).numberOfChannels()) { 82 if (numberOfChannels != output(0).numberOfChannels()) {
83 // This will propagate the channel count to any nodes connected further downstream in the graph. 83 // This will propagate the channel count to any nodes connected further downstream in the graph.
84 output(0).setNumberOfChannels(numberOfChannels); 84 output(0).setNumberOfChannels(numberOfChannels);
85 } 85 }
86 86
(...skipping 23 matching lines...) Expand all
110 } else if (!numberOfInputConnections && m_needAutomaticPull) { 110 } else if (!numberOfInputConnections && m_needAutomaticPull) {
111 // The AudioBasicInspectorNode is connected to nothing, remove it fr om the context's automatic pull list. 111 // The AudioBasicInspectorNode is connected to nothing, remove it fr om the context's automatic pull list.
112 context()->deferredTaskHandler().removeAutomaticPullNode(this); 112 context()->deferredTaskHandler().removeAutomaticPullNode(this);
113 m_needAutomaticPull = false; 113 m_needAutomaticPull = false;
114 } 114 }
115 } 115 }
116 } 116 }
117 117
118 } // namespace blink 118 } // namespace blink
119 119
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698