third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp - Issue 2159403002: Replace ASSERT with DCHECK in WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

Issue 2159403002: Replace ASSERT with DCHECK in WebAudio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp ('k') | third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp » ('j') | third_party/WebKit/Source/modules/webaudio/AudioBasicInspectorNode.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp b/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

index 360ad1ad664aa7dd55453efa7d9fd87716f4a40c..9cb9a009640f9bed617a700e89c01785a0993152 100644

--- a/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp

@@ -47,8 +47,8 @@ AsyncAudioDecoder::~AsyncAudioDecoder()

void AsyncAudioDecoder::decodeAsync(DOMArrayBuffer* audioData, float sampleRate, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, ScriptPromiseResolver* resolver, AbstractAudioContext* context)

{

- ASSERT(isMainThread());

- ASSERT(audioData);

+ DCHECK(isMainThread());

+ DCHECK(audioData);

if (!audioData)

return;

@@ -66,7 +66,7 @@ void AsyncAudioDecoder::decode(DOMArrayBuffer* audioData, float sampleRate, Audi

void AsyncAudioDecoder::notifyComplete(DOMArrayBuffer*, AudioBufferCallback* successCallback, AudioBufferCallback* errorCallback, AudioBus* audioBus, ScriptPromiseResolver* resolver, AbstractAudioContext* context)

{

- ASSERT(isMainThread());

+ DCHECK(isMainThread());

AudioBuffer* audioBuffer = AudioBuffer::createFromAudioBus(audioBus);