Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2159253002: [system health] Fix load:news:washingtonpost and browse:news:washingtonpost on Nexus9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/system_health/browsing_stories.py
diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py
index 388e0ee5c3ea0c46d6988163c40715dbe8192216..9611e927ea95e83bbc0f42aea8cf2bec68ecd888 100644
--- a/tools/perf/page_sets/system_health/browsing_stories.py
+++ b/tools/perf/page_sets/system_health/browsing_stories.py
@@ -182,6 +182,9 @@ class WashingtonPostMobileStory(_NewsBrowsingStory):
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
def _DidLoadDocument(self, action_runner):
- # Close the popup window.
- action_runner.ClickElement(selector='.close')
+ # Close the popup window. On Nexus 9 (and probably other tables) the popup
petrcermak 2016/07/19 16:51:58 How about we do something a little more hacky: ac
ulan 2016/07/19 17:26:42 Acknowledged.
+ # window does not have "Close" button, instead it has only "Send link to
petrcermak 2016/07/19 17:07:08 supernit: s/have "Close"/have a "Close/ and s/only
ulan 2016/07/19 17:26:42 Done.
+ # phone" button, which does nothing. So on tablets we run with popup
petrcermak 2016/07/19 17:07:08 nit: s/popup/the popup/
ulan 2016/07/19 17:26:42 Done.
+ # window open.
petrcermak 2016/07/19 17:07:08 Please add a sentence (along the lines of your rep
ulan 2016/07/19 17:26:42 Done.
+ action_runner.ClickElement(selector='.close,.mailBlock')
petrcermak 2016/07/19 17:08:48 On a second thought, I think it would be better no
ulan 2016/07/19 17:26:42 Done. Added a check.
super(WashingtonPostMobileStory, self)._DidLoadDocument(action_runner)

Powered by Google App Engine
This is Rietveld 408576698