tools/perf/page_sets/system_health/loading_stories.py - Issue 2159253002: [system health] Fix load:news:washingtonpost and browse:news:washingtonpost on Nexus9.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/system_health/loading_stories.py

Issue 2159253002: [system health] Fix load:news:washingtonpost and browse:news:washingtonpost on Nexus9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/system_health/loading_stories.py

diff --git a/tools/perf/page_sets/system_health/loading_stories.py b/tools/perf/page_sets/system_health/loading_stories.py

index 71ec4ff460323d4dfb4fa7d50edafc80911305ee..9f5deae2c12ba59de2a1e9d60aaa0a0cfa813a28 100644

--- a/tools/perf/page_sets/system_health/loading_stories.py

+++ b/tools/perf/page_sets/system_health/loading_stories.py

@@ -174,8 +174,11 @@ class LoadWashingtonPostMobileStory(_LoadingStory):

SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY

def _DidLoadDocument(self, action_runner):

- # Close the popup window.

- action_runner.ClickElement(selector='.close')

+ # Close the popup window. On Nexus 9 (and probably other tables) the popup

petrcermak 2016/07/19 17:07:08 ditto (everything that applies to the previous com

+ # window does not have "Close" button, instead it has only "Send link to

+ # phone" button, which does nothing. So on tablets we run with popup

+ # window open.

+ action_runner.ClickElement(selector='.close,.mailBlock')

class LoadWikipediaStory(_LoadingStory):

« tools/perf/page_sets/system_health/browsing_stories.py ('K') | « tools/perf/page_sets/system_health/browsing_stories.py ('k') | no next file » | no next file with comments »