tools/perf/page_sets/system_health/browsing_stories.py - Issue 2159253002: [system health] Fix load:news:washingtonpost and browse:news:washingtonpost on Nexus9.

Side by Side Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2159253002: [system health] Fix load:news:washingtonpost and browse:news:washingtonpost on Nexus9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from page_sets.system_health import platforms	5 from page_sets.system_health import platforms

6 from page_sets.system_health import system_health_story	6 from page_sets.system_health import system_health_story

7	7

8	8

9 class _BrowsingStory(system_health_story.SystemHealthStory):	9 class _BrowsingStory(system_health_story.SystemHealthStory):

10 """Abstract base class for browsing stories.	10 """Abstract base class for browsing stories.

(...skipping 164 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
175	175

176 class WashingtonPostMobileStory(_NewsBrowsingStory):	176 class WashingtonPostMobileStory(_NewsBrowsingStory):

177 """Progressive website"""	177 """Progressive website"""

178 NAME = 'browse:news:washingtonpost'	178 NAME = 'browse:news:washingtonpost'

179 URL = 'https://www.washingtonpost.com/pwa'	179 URL = 'https://www.washingtonpost.com/pwa'

180 IS_SINGLE_PAGE_APP = True	180 IS_SINGLE_PAGE_APP = True

181 ITEM_SELECTOR = '.hed > a'	181 ITEM_SELECTOR = '.hed > a'

182 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY	182 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY

183	183

184 def _DidLoadDocument(self, action_runner):	184 def _DidLoadDocument(self, action_runner):

185 # Close the popup window.	185 # Close the popup window. On Nexus 9 (and probably other tables) the popup
	petrcermak 2016/07/19 16:51:58 How about we do something a little more hacky: ac How about we do something a little more hacky: action_runner.ExecuteJavaScript('''(function() { var elem = document.querySelector('div#welcome'); if (elem) elem.parentNode.removeChild(elem); })()'''); ulan 2016/07/19 17:26:42 Acknowledged. Show quoted text On 2016/07/19 16:51:58, petrcermak wrote: > How about we do something a little more hacky: > > action_runner.ExecuteJavaScript('''(function() { > var elem = document.querySelector('div#welcome'); > if (elem) > elem.parentNode.removeChild(elem); > })()'''); Acknowledged.
186 action_runner.ClickElement(selector='.close')	186 # window does not have "Close" button, instead it has only "Send link to
	petrcermak 2016/07/19 17:07:08 supernit: s/have "Close"/have a "Close/ and s/only supernit: s/have "Close"/have a "Close/ and s/only "Send/only a "Send/ ulan 2016/07/19 17:26:42 Done. Show quoted text On 2016/07/19 17:07:08, petrcermak wrote: > supernit: s/have "Close"/have a "Close/ and s/only "Send/only a "Send/ Done.
	187 # phone" button, which does nothing. So on tablets we run with popup
	petrcermak 2016/07/19 17:07:08 nit: s/popup/the popup/ nit: s/popup/the popup/ ulan 2016/07/19 17:26:42 Done. Show quoted text On 2016/07/19 17:07:08, petrcermak wrote: > nit: s/popup/the popup/ Done.
	188 # window open.
	petrcermak 2016/07/19 17:07:08 Please add a sentence (along the lines of your rep Please add a sentence (along the lines of your reply): "The popup is transparent, so this is mostly an aesthetical issue." ulan 2016/07/19 17:26:42 Done. Show quoted text On 2016/07/19 17:07:08, petrcermak wrote: > Please add a sentence (along the lines of your reply): "The popup is > transparent, so this is mostly an aesthetical issue." Done.
	189 action_runner.ClickElement(selector='.close,.mailBlock')
	petrcermak 2016/07/19 17:08:48 On a second thought, I think it would be better no On a second thought, I think it would be better not to click any button if there's no "close" button. ulan 2016/07/19 17:26:42 Done. Added a check. Show quoted text On 2016/07/19 17:08:48, petrcermak wrote: > On a second thought, I think it would be better not to click any button if > there's no "close" button. Done. Added a check.
187 super(WashingtonPostMobileStory, self)._DidLoadDocument(action_runner)	190 super(WashingtonPostMobileStory, self)._DidLoadDocument(action_runner)

OLD	NEW

« no previous file with comments | « no previous file | tools/perf/page_sets/system_health/loading_stories.py » ('j') | tools/perf/page_sets/system_health/loading_stories.py » ('J')