Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2159133003: Remove find in page from CCT, remove bookmark star from Herbs (Closed)

Created:
4 years, 5 months ago by Ted C
Modified:
4 years, 5 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove find in page from CCT, remove bookmark star from Herbs BUG=625315 Committed: https://crrev.com/6a79bc344d73f115ab33bd80405e8de06441b44d Cr-Commit-Position: refs/heads/master@{#406731}

Patch Set 1 #

Patch Set 2 : Fix test expectations due to menu items being removed #

Messages

Total messages: 13 (6 generated)
Ted C
PTAL Leaving it the find in page manager in CustomTabActivity as I think it will ...
4 years, 5 months ago (2016-07-19 22:25:03 UTC) #2
Yusuf
lgtm
4 years, 5 months ago (2016-07-19 22:43:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159133003/1
4 years, 5 months ago (2016-07-19 22:48:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/106836)
4 years, 5 months ago (2016-07-20 03:04:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159133003/20001
4 years, 5 months ago (2016-07-20 23:54:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 00:46:25 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 00:47:46 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6a79bc344d73f115ab33bd80405e8de06441b44d
Cr-Commit-Position: refs/heads/master@{#406731}

Powered by Google App Engine
This is Rietveld 408576698