Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2992)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java

Issue 2159133003: Remove find in page from CCT, remove bookmark star from Herbs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test expectations due to menu items being removed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
index 0e1103531fef057de5a526d2e584c6d0b17415eb..74d95abb63d7b21d1d0c202fd8d73c2a07b917b9 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
@@ -110,7 +110,7 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
private static final String READ_IT_LATER_FEATURE = "ReadItLaterInMenu";
private static final int MAX_MENU_CUSTOM_ITEMS = 5;
- private static final int NUM_CHROME_MENU_ITEMS = 3;
+ private static final int NUM_CHROME_MENU_ITEMS = 2;
private static final String
TEST_ACTION = "org.chromium.chrome.browser.customtabs.TEST_PENDING_INTENT_SENT";
private static final String TEST_PAGE = "/chrome/test/data/android/google.html";
@@ -357,11 +357,11 @@ public class CustomTabActivityTest extends CustomTabActivityTestBase {
assertNotNull(menu.findItem(R.id.forward_menu_id));
assertNotNull(menu.findItem(R.id.info_menu_id));
assertNotNull(menu.findItem(R.id.reload_menu_id));
- assertNotNull(menu.findItem(R.id.find_in_page_id));
assertNotNull(menu.findItem(R.id.open_in_browser_id));
assertFalse(menu.findItem(R.id.share_row_menu_id).isVisible());
assertFalse(menu.findItem(R.id.share_row_menu_id).isEnabled());
assertNull(menu.findItem(R.id.bookmark_this_page_id));
+ assertNull(menu.findItem(R.id.find_in_page_id));
}
/**
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698