Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 2159133003: Remove find in page from CCT, remove bookmark star from Herbs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test expectations due to menu items being removed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index 7cf55abc69968d6dae3e59e54475e1fd6e261545..d29d305fbe93421ee8de7a180eb26cd7ae8f3524 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -40,7 +40,6 @@ import org.chromium.chrome.browser.IntentHandler.ExternalAppId;
import org.chromium.chrome.browser.KeyboardShortcuts;
import org.chromium.chrome.browser.WebContentsFactory;
import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
-import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
import org.chromium.chrome.browser.compositor.layouts.LayoutManagerDocument;
import org.chromium.chrome.browser.datausage.DataUseTabUIManager;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
@@ -500,7 +499,6 @@ public class CustomTabActivity extends ChromeActivity {
protected AppMenuPropertiesDelegate createAppMenuPropertiesDelegate() {
return new CustomTabAppMenuPropertiesDelegate(this, mIntentDataProvider.getMenuTitles(),
mIntentDataProvider.shouldShowShareMenuItem(),
- mIntentDataProvider.shouldShowBookmarkMenuItem(),
mIntentDataProvider.isOpenedByChrome());
}
@@ -636,9 +634,6 @@ public class CustomTabActivity extends ChromeActivity {
|| id == R.id.recent_tabs_menu_id || id == R.id.new_incognito_tab_menu_id
|| id == R.id.new_tab_menu_id || id == R.id.open_history_menu_id) {
return true;
- } else if (id == R.id.bookmark_this_page_id
- && !mIntentDataProvider.shouldShowBookmarkMenuItem()) {
- return true;
} else if (id == R.id.open_in_browser_id) {
openCurrentUrlInBrowser(false, true);
RecordUserAction.record("CustomTabsMenuOpenInChrome");
@@ -647,17 +642,6 @@ public class CustomTabActivity extends ChromeActivity {
openCurrentUrlInBrowser(false, false);
RecordUserAction.record("CustomTabsMenuReadItLater");
return true;
- } else if (id == R.id.find_in_page_id) {
- mFindToolbarManager.showToolbar();
- if (getContextualSearchManager() != null) {
- getContextualSearchManager().hideContextualSearch(StateChangeReason.UNKNOWN);
- }
- if (fromMenu) {
- RecordUserAction.record("MobileMenuFindInPage");
- } else {
- RecordUserAction.record("MobileShortcutFindInPage");
- }
- return true;
} else if (id == R.id.info_menu_id) {
if (getTabModelSelector().getCurrentTab() == null) return false;
WebsiteSettingsPopup.show(

Powered by Google App Engine
This is Rietveld 408576698