Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2159003002: Fix the v8 snapshots in the GN mipsel, mips64el builds. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the v8 snapshots in the GN mipsel, mips64el builds. This also deletes references to gcc-based snapshot toolchains that don't actually exist. Let's find out if they're actually needed anywhere ;). The mips build was broken by the v8_target_cpu changes for 625353. TBR=machenbach@chromium.org BUG=625353, 629057 Committed: https://crrev.com/fb1cadc07b5b8f97f1ef5ee9800a47ce6f6fe902 Cr-Commit-Position: refs/heads/master@{#406174}

Patch Set 1 #

Patch Set 2 : add mips64el as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M build/config/v8_target_cpu.gni View 1 1 chunk +8 lines, -4 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 1 2 chunks +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (10 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-18 21:24:56 UTC) #1
Dirk Pranke
4 years, 5 months ago (2016-07-18 21:27:51 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2158143002 Patch 20001). Please resolve the dependency and ...
4 years, 5 months ago (2016-07-18 21:28:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159003002/20001
4 years, 5 months ago (2016-07-18 22:17:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/105943)
4 years, 5 months ago (2016-07-18 23:47:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2159003002/20001
4 years, 5 months ago (2016-07-19 00:00:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 01:54:34 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fb1cadc07b5b8f97f1ef5ee9800a47ce6f6fe902 Cr-Commit-Position: refs/heads/master@{#406174}
4 years, 5 months ago (2016-07-19 01:58:27 UTC) #18
Michael Achenbach
4 years, 5 months ago (2016-07-20 08:42:39 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698