build/config/v8_target_cpu.gni - Issue 2159003002: Fix the v8 snapshots in the GN mipsel, mips64el builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/v8_target_cpu.gni

Issue 2159003002: Fix the v8 snapshots in the GN mipsel, mips64el builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add mips64el as well Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/v8_target_cpu.gni

diff --git a/build/config/v8_target_cpu.gni b/build/config/v8_target_cpu.gni

index 6a7c1a3774751a28f126b317c9c3dd03af43ec37..13755d2be5076f1761a23873fcacbccfe8ca9d2f 100644

--- a/build/config/v8_target_cpu.gni

+++ b/build/config/v8_target_cpu.gni

@@ -34,12 +34,16 @@ declare_args() {

}

if (v8_target_cpu == "") {

- if (current_toolchain == "//build/toolchain/linux:clang_x64_v8_arm64" ||

- current_toolchain == "//build/toolchain/linux:x64_v8_arm64") {

+ if (current_toolchain == "//build/toolchain/linux:clang_x64_v8_arm64") {

v8_target_cpu = "arm64"

- } else if (current_toolchain == "//build/toolchain/linux:clang_x86_v8_arm" ||

- current_toolchain == "//build/toolchain/linux:x86_v8_arm") {

+ } else if (current_toolchain == "//build/toolchain/linux:clang_x86_v8_arm") {

v8_target_cpu = "arm"

+ } else if (current_toolchain ==

+ "//build/toolchain/linux:clang_x86_v8_mips64el") {

+ v8_target_cpu = "mips64el"

+ } else if (current_toolchain ==

+ "//build/toolchain/linux:clang_x86_v8_mipsel") {

+ v8_target_cpu = "mipsel"

} else if (is_msan) {

# If we're running under a sanitizer, if we configure v8 to generate

# code that will be run under a simulator, then the generated code

« no previous file with comments | « no previous file | build/toolchain/linux/BUILD.gn » ('j') | no next file with comments »