Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2158143002: Re-land r405933 w/ fix for CrOS. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews, wuchengli
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land r405933 w/ fix for CrOS. This CL re-lands r405933 and removes the hack that was needed while rolling in the reworked v8_target_cpu code, but this adds the missing line that was needed for CrOS to work correctly with their custom toolchain. TBR=machenbach@chromium.org, llozano@chromium.org BUG=593461, 625353 Committed: https://crrev.com/702414254eea4221cc4d36eb1ca4c1f9636699c1 Cr-Commit-Position: refs/heads/master@{#406115}

Patch Set 1 #

Patch Set 2 : fix to set v8_toolchain_cpu/v8_current_cpu correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M build/toolchain/cros/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Dirk Pranke
The problem with the original CL is that, in non-CrOS builds, the build files figure ...
4 years, 5 months ago (2016-07-18 19:28:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158143002/20001
4 years, 5 months ago (2016-07-18 19:29:22 UTC) #3
Michael Achenbach
lgtm
4 years, 5 months ago (2016-07-18 19:34:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/246714)
4 years, 5 months ago (2016-07-18 20:37:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158143002/20001
4 years, 5 months ago (2016-07-18 21:06:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 22:03:47 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 22:05:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/702414254eea4221cc4d36eb1ca4c1f9636699c1
Cr-Commit-Position: refs/heads/master@{#406115}

Powered by Google App Engine
This is Rietveld 408576698