Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
TBR=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js

Committed: https://chromium.googlesource.com/chromium/src/+/b3886ee26a2c21918dfef818c101569dce1b51a9

[Dan Beam, 2016-07-21 19:47:39]

Description was changed from

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
BUG=629710
==========

to

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-21 19:52:44]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 19:53:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 20:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:03:26]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Dan Beam, 2016-07-21 20:08:31]

Description was changed from

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js
==========

[michaelpg, 2016-07-21 23:12:28]

lgtm

https://codereview.chromium.org/2158913007/diff/1/third_party/polymer/v1_0/ch...
File third_party/polymer/v1_0/chromium.patch (right):

https://codereview.chromium.org/2158913007/diff/1/third_party/polymer/v1_0/ch...
third_party/polymer/v1_0/chromium.patch:35: +MODULE_STYLES_SELECTOR:
'style:not([no-process]), link[rel=import][type~=css], template',
do we still need this?

[Dan Beam, 2016-07-21 23:16:12]

https://codereview.chromium.org/2158913007/diff/1/third_party/polymer/v1_0/ch...
File third_party/polymer/v1_0/chromium.patch (right):

https://codereview.chromium.org/2158913007/diff/1/third_party/polymer/v1_0/ch...
third_party/polymer/v1_0/chromium.patch:35: +MODULE_STYLES_SELECTOR:
'style:not([no-process]), link[rel=import][type~=css], template',
On 2016/07/21 23:12:27, michaelpg wrote:
> do we still need this?

yeah, for now, really just because we actually have <style no-process> that
still exist and I'm trying to minimize the chance of reverting this roll or
breaking those styles.

i will investigate removing it soon, though.

[Dan Beam, 2016-07-21 23:16:21]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-21 23:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 00:09:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:09:18]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Dan Beam, 2016-07-22 00:57:28]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:58:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-07-22 01:31:16]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-07-23 01:29:01]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 01:29:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 02:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 02:28:30]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-07-23 07:21:27]

not lgtm... too many issues :'(

https://github.com/Polymer/polymer/issues/3802
https://github.com/Polymer/polymer/issues/3803

this affects the search box in cr-toolbar, as well as the keyboard focus state
of paper-buttons in dialogs.

it also causes dropdown menus to no longer use the pointer cursor.

[michaelpg, 2016-07-24 00:20:19]

On 2016/07/23 07:21:27, michaelpg wrote:
> not lgtm... too many issues :'(
> 
> https://github.com/Polymer/polymer/issues/3802
> https://github.com/Polymer/polymer/issues/3803
> 
> this affects the search box in cr-toolbar, as well as the keyboard focus state
> of paper-buttons in dialogs.
> 
> it also causes dropdown menus to no longer use the pointer cursor.

in the MD user manager "Add person" dialog, the profile name input font is
wrong, and the profile icon buttons should have background colors depending on
focus state but have no background at all. The "Select an Account" dropdown menu
for supervised users is also screwed up, and the import dialog has the wrong
dimensions and fonts.

Basically: everything is FUBAR unless we disable useNativeCSSProperties before
the roll.

[Dan Beam, 2016-07-25 23:54:47]

Description was changed from

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js
==========

to

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

TBR=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js
==========

[Dan Beam, 2016-07-25 23:55:40]

On 2016/07/24 00:20:19, michaelpg wrote:
> On 2016/07/23 07:21:27, michaelpg wrote:
> > not lgtm... too many issues :'(
> > 
> > https://github.com/Polymer/polymer/issues/3802
> > https://github.com/Polymer/polymer/issues/3803
> > 
> > this affects the search box in cr-toolbar, as well as the keyboard focus
state
> > of paper-buttons in dialogs.
> > 
> > it also causes dropdown menus to no longer use the pointer cursor.
> 
> in the MD user manager "Add person" dialog, the profile name input font is
> wrong, and the profile icon buttons should have background colors depending on
> focus state but have no background at all. The "Select an Account" dropdown
menu
> for supervised users is also screwed up, and the import dialog has the wrong
> dimensions and fonts.
> 
> Basically: everything is FUBAR unless we disable useNativeCSSProperties before
> the roll.

disabled custom properties here: https://codereview.chromium.org/2181073002/

[Dan Beam, 2016-07-25 23:55:50]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-25 23:56:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 23:56:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 23:56:34]

A disapproval has been posted by following reviewers: michaelpg@chromium.org.
Please make sure to get positive review before another CQ attempt.

[Dan Beam, 2016-07-26 00:16:35]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 00:17:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 02:17:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 02:17:25]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[commit-bot: I haz the power, 2016-07-26 02:29:28]

Description was changed from

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

TBR=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js
==========

to

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
TBR=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js

Committed: https://crrev.com/b3886ee26a2c21918dfef818c101569dce1b51a9
Cr-Commit-Position: refs/heads/master@{#407689}
==========

[commit-bot: I haz the power, 2016-07-26 02:29:30]

Patchset 3 (id:??) landed as
https://crrev.com/b3886ee26a2c21918dfef818c101569dce1b51a9
Cr-Commit-Position: refs/heads/master@{#407689}

[Dan Beam, 2016-07-26 02:30:40]

Description was changed from

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
TBR=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js

Committed: https://crrev.com/b3886ee26a2c21918dfef818c101569dce1b51a9
Cr-Commit-Position: refs/heads/master@{#407689}
==========

to

==========
Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props

R=michaelpg@chromium.org
TBR=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js

Committed:
https://chromium.googlesource.com/chromium/src/+/b3886ee26a2c21918dfef818c101...
==========

[Dan Beam, 2016-07-26 02:30:42]

Committed patchset #3 (id:40001) manually as
b3886ee26a2c21918dfef818c101569dce1b51a9 (presubmit successful).

[Dan Beam, 2016-07-26 02:42:12]

damn, just re-read this CL description

NOTE: no custom props were actually harnessed in this roll :(

[michaelpg, 2016-07-26 04:01:15]

lgtm