Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2172833002: MD Downloads: finally use allow-outside-scroll and drop the pushScrollLock hack (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@roll-polymer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: finally use allow-outside-scroll and drop the pushScrollLock hack R=michaelpg@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOPRESUBMIT=true # crisper.js Committed: https://crrev.com/6da4b1209171d46d4034025df5fb3b53bcf5292a Cr-Commit-Position: refs/heads/master@{#407692}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (14 generated)
Dan Beam
4 years, 5 months ago (2016-07-21 22:58:39 UTC) #2
michaelpg
lgtm
4 years, 5 months ago (2016-07-21 23:42:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172833002/20001
4 years, 4 months ago (2016-07-26 02:47:31 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 02:48:21 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 02:49:57 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6da4b1209171d46d4034025df5fb3b53bcf5292a
Cr-Commit-Position: refs/heads/master@{#407692}

Powered by Google App Engine
This is Rietveld 408576698