Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js

Issue 2158913007: Roll Polymer from 1.5.0 -> 1.6.0 to pick up native CSS custom props (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js
diff --git a/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js b/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js
index 64aff8b652ac0063efaafd949644588d188907b0..0dd39eef79ae7701573d9f0a1d539526ef9be1ac 100644
--- a/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js
+++ b/third_party/polymer/v1_0/components-chromium/paper-dialog-behavior/paper-dialog-behavior-extracted.js
@@ -26,7 +26,7 @@ to include `confirmed: true`.
This element has `role="dialog"` by default. Depending on the context, it may be more appropriate
to override this attribute with `role="alertdialog"`.
-If `modal` is set, the element will set `aria-modal` and prevent the focus from exiting the element.
+If `modal` is set, the element will prevent the focus from exiting the element.
It will also ensure that focus remains in the dialog.
@hero hero.svg
@@ -69,12 +69,6 @@ It will also ensure that focus remains in the dialog.
},
_modalChanged: function(modal, readied) {
- if (modal) {
- this.setAttribute('aria-modal', 'true');
- } else {
- this.setAttribute('aria-modal', 'false');
- }
-
// modal implies noCancelOnOutsideClick, noCancelOnEscKey and withBackdrop.
// We need to wait for the element to be ready before we can read the
// properties values.

Powered by Google App Engine
This is Rietveld 408576698