Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2158753002: Adding the creation_flags back to pending_extension_info. Add a unit test to cover the case when an… (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Adding the creation_flags back to pending_extension_info. Add a unit test to cover the case when an external extension is updated before being installed and make sure it retains the creation flags. BUG=627522 Review-Url: https://codereview.chromium.org/2146963004 Cr-Commit-Position: refs/heads/master@{#405856} (cherry picked from commit 0128d5a9b0a402cd85aa0ef409c73f3ad1df548c) Committed: https://chromium.googlesource.com/chromium/src/+/7fb006083710f482493a5643509fedc6f399cd4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M chrome/browser/extensions/pending_extension_info.h View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/pending_extension_info.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 6 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 5 months ago (2016-07-18 08:23:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7fb006083710f482493a5643509fedc6f399cd4a.

Powered by Google App Engine
This is Rietveld 408576698