Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/extensions/pending_extension_manager.cc

Issue 2158753002: Adding the creation_flags back to pending_extension_info. Add a unit test to cover the case when an… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/pending_extension_manager.cc
diff --git a/chrome/browser/extensions/pending_extension_manager.cc b/chrome/browser/extensions/pending_extension_manager.cc
index 601bc3af29518ef814643e2bb78e7794c4d50abd..9014cc92c62110ad43bc4651e9c259269186528f 100644
--- a/chrome/browser/extensions/pending_extension_manager.cc
+++ b/chrome/browser/extensions/pending_extension_manager.cc
@@ -120,6 +120,7 @@ bool PendingExtensionManager::AddFromSync(
should_allow_install,
kIsFromSync,
kSyncLocation,
+ Extension::NO_FLAGS,
kMarkAcknowledged,
remote_install);
}
@@ -149,6 +150,7 @@ bool PendingExtensionManager::AddFromExtensionImport(
should_allow_install,
kIsFromSync,
kManifestLocation,
+ Extension::NO_FLAGS,
kMarkAcknowledged,
kRemoteInstall);
}
@@ -189,6 +191,7 @@ bool PendingExtensionManager::AddFromExternalUpdateUrl(
&AlwaysInstall,
kIsFromSync,
location,
+ creation_flags,
mark_acknowledged,
kRemoteInstall);
}
@@ -215,6 +218,7 @@ bool PendingExtensionManager::AddFromExternalFile(
&AlwaysInstall,
kIsFromSync,
install_source,
+ creation_flags,
mark_acknowledged,
kRemoteInstall);
}
@@ -248,6 +252,7 @@ bool PendingExtensionManager::AddExtensionImpl(
PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install,
bool is_from_sync,
Manifest::Location install_source,
+ int creation_flags,
bool mark_acknowledged,
bool remote_install) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -259,6 +264,7 @@ bool PendingExtensionManager::AddExtensionImpl(
should_allow_install,
is_from_sync,
install_source,
+ creation_flags,
mark_acknowledged,
remote_install);
« no previous file with comments | « chrome/browser/extensions/pending_extension_manager.h ('k') | chrome/browser/extensions/updater/extension_updater_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698