Adding the creation flags back to pending extension info.

Adding the creation_flags back to pending_extension_info.
Add a unit test to cover the case when an external extension
is updated before being installed and make sure it retains
the creation flags.

BUG=627522
Committed: https://crrev.com/0128d5a9b0a402cd85aa0ef409c73f3ad1df548c
Cr-Commit-Position: refs/heads/master@{#405856}

[mamir, 2016-07-14 11:58:01]

Description was changed from

==========
Adding the creation flags back to pending extension info.

BUG=627522
==========

to

==========
Adding the creation_flags back to pending_extension_info.

BUG=627522
==========

[mamir, 2016-07-14 11:58:14]

mamir@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2016-07-14 15:02:39]

We should definitely add a test for this, so that we don't regress again.

Additionally, these have been removed for a couple weeks.  That might mean that
any extensions that went through this process (most notably bundled extensions)
are still missing the creation flags.  We should test that, and fix it if it's
broken (by retroactively updating the creation flags when we load up the
extension).

https://codereview.chromium.org/2146963004/diff/1/chrome/browser/extensions/p...
File chrome/browser/extensions/pending_extension_info.cc (right):

https://codereview.chromium.org/2146963004/diff/1/chrome/browser/extensions/p...
chrome/browser/extensions/pending_extension_info.cc:39: creation_flags_(0),
nit: prefer NO_FLAGS constant.

[mamir, 2016-07-15 18:57:05]

Description was changed from

==========
Adding the creation_flags back to pending_extension_info.

BUG=627522
==========

to

==========
Adding the creation_flags back to pending_extension_info.
Add a unit test to cover the case when an external extension
is updated before being installed and make sure it retains
the creation flags.

BUG=627522
==========

[mamir, 2016-07-15 18:58:14]

https://codereview.chromium.org/2146963004/diff/1/chrome/browser/extensions/p...
File chrome/browser/extensions/pending_extension_info.cc (right):

https://codereview.chromium.org/2146963004/diff/1/chrome/browser/extensions/p...
chrome/browser/extensions/pending_extension_info.cc:39: creation_flags_(0),
On 2016/07/14 15:02:39, Devlin wrote:
> nit: prefer NO_FLAGS constant.

Done.

[Devlin, 2016-07-15 19:02:40]

Fantastic, great job on the test!

LGTM

https://codereview.chromium.org/2146963004/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/2146963004/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:4185:
TEST_F(ExtensionServiceTest, UpdatingPendingExternalExtensionWithFlags) {
Let's add a comment:
// Regression test for crbug.com/***

[mamir, 2016-07-15 19:06:20]

Thank you Devlin for your help during this.

https://codereview.chromium.org/2146963004/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/2146963004/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:4185:
TEST_F(ExtensionServiceTest, UpdatingPendingExternalExtensionWithFlags) {
On 2016/07/15 19:02:40, Devlin wrote:
> Let's add a comment:
> // Regression test for crbug.com/***

Done.

[mamir, 2016-07-15 19:06:36]

The CQ bit was checked by mamir@chromium.org

[mamir, 2016-07-15 19:06:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2146963004/#ps60001
(title: "Minor comment")

[commit-bot: I haz the power, 2016-07-15 19:07:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 20:08:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:08:43]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Devlin, 2016-07-15 20:20:12]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:20:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 20:56:01]

Description was changed from

==========
Adding the creation_flags back to pending_extension_info.
Add a unit test to cover the case when an external extension
is updated before being installed and make sure it retains
the creation flags.

BUG=627522
==========

to

==========
Adding the creation_flags back to pending_extension_info.
Add a unit test to cover the case when an external extension
is updated before being installed and make sure it retains
the creation flags.

BUG=627522
==========

[commit-bot: I haz the power, 2016-07-15 20:56:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-15 20:56:10]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 20:58:59]

Description was changed from

==========
Adding the creation_flags back to pending_extension_info.
Add a unit test to cover the case when an external extension
is updated before being installed and make sure it retains
the creation flags.

BUG=627522
==========

to

==========
Adding the creation_flags back to pending_extension_info.
Add a unit test to cover the case when an external extension
is updated before being installed and make sure it retains
the creation flags.

BUG=627522

Committed: https://crrev.com/0128d5a9b0a402cd85aa0ef409c73f3ad1df548c
Cr-Commit-Position: refs/heads/master@{#405856}
==========

[commit-bot: I haz the power, 2016-07-15 20:59:00]

Patchset 4 (id:??) landed as
https://crrev.com/0128d5a9b0a402cd85aa0ef409c73f3ad1df548c
Cr-Commit-Position: refs/heads/master@{#405856}