third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp - Issue 2158723002: Make CSSValuePair store const CSSValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp

Issue 2158723002: Make CSSValuePair store const CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_cssparsersinglevalue_return_const

Patch Set: Review feedback Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp ('k') | third_party/WebKit/Source/core/css/CSSGradientValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp b/third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp

index 96b71234f06f5e1e4b94ba928196f18b526eb694..b361d43e3db6ad761c5e9090bec5e5f304a58a33 100644

--- a/third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp

+++ b/third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp

@@ -71,7 +71,7 @@ static String serializePositionOffset(const CSSValuePair& offset, const CSSValue

static CSSValuePair* buildSerializablePositionOffset(CSSValue* offset, CSSValueID defaultSide)

{

CSSValueID side = defaultSide;

- CSSPrimitiveValue* amount = nullptr;

+ const CSSPrimitiveValue* amount = nullptr;

if (!offset) {

side = CSSValueCenter;