Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2158603003: Add DocWrite.Block metric for NavigationToFirstContentfulPaint. (Closed)

Created:
4 years, 5 months ago by Bryan McQuade
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Add DocWrite.Block metric for NavigationToFirstContentfulPaint. We have ParseStartToFirstContentfulPaint for DocWrite.Block, which is useful for understanding the exact impact of the change on the period from parse start to FCP, but it's also important to measure the overall time from navigation to FCP. This change adds a metric to track this overall time. BUG=626945 TBR=shivanisha NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2140443002 Cr-Commit-Position: refs/heads/master@{#404660} (cherry picked from commit 10ff30f72b8ac4d842ea154f29420a946a463b66)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158603003/1
4 years, 5 months ago (2016-07-16 17:05:26 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-16 17:05:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158603003/1
4 years, 5 months ago (2016-07-16 17:07:17 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-16 17:07:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158603003/1
4 years, 5 months ago (2016-07-16 17:08:46 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-16 17:10:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698