Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2140443002: Add DocWrite.Block metric for NavigationToFirstContentfulPaint. (Closed)

Created:
4 years, 5 months ago by Bryan McQuade
Modified:
4 years, 5 months ago
Reviewers:
shivanisha
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DocWrite.Block metric for NavigationToFirstContentfulPaint. We have ParseStartToFirstContentfulPaint for DocWrite.Block, which is useful for understanding the exact impact of the change on the period from parse start to FCP, but it's also important to measure the overall time from navigation to FCP. This change adds a metric to track this overall time. BUG=626945 Committed: https://crrev.com/10ff30f72b8ac4d842ea154f29420a946a463b66 Cr-Commit-Position: refs/heads/master@{#404660}

Patch Set 1 #

Patch Set 2 : fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bryan McQuade
ptal
4 years, 5 months ago (2016-07-11 12:43:58 UTC) #2
shivanisha
On 2016/07/11 at 12:43:58, bmcquade wrote: > ptal LGTM
4 years, 5 months ago (2016-07-11 15:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140443002/20001
4 years, 5 months ago (2016-07-11 15:13:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 15:17:06 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 15:17:14 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 15:18:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10ff30f72b8ac4d842ea154f29420a946a463b66
Cr-Commit-Position: refs/heads/master@{#404660}

Powered by Google App Engine
This is Rietveld 408576698