Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Issue 2158603003: Add DocWrite.Block metric for NavigationToFirstContentfulPaint. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
index bc18f8eb87f25c0f75774b0cd1c503480e675f0b..3093232f15b017f2121c21b544a76ff0826b2ea6 100644
--- a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
@@ -103,6 +103,9 @@ const char
[] = "PageLoad.Clients.DocWrite.Evaluator.ParseTiming."
"ParseBlockedOnScriptLoadFromDocumentWrite.Background";
+const char kHistogramDocWriteBlockFirstContentfulPaintImmediate[] =
+ "PageLoad.Clients.DocWrite.Block.PaintTiming."
+ "NavigationToFirstContentfulPaint";
const char kHistogramDocWriteBlockParseStartToFirstContentfulPaintImmediate[] =
"PageLoad.Clients.DocWrite.Block.PaintTiming."
"ParseStartToFirstContentfulPaint";
@@ -299,6 +302,9 @@ void DocumentWritePageLoadMetricsObserver::
if (WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
info)) {
PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramDocWriteBlockFirstContentfulPaintImmediate,
+ timing.first_contentful_paint);
+ PAGE_LOAD_HISTOGRAM(
internal::
kHistogramDocWriteBlockParseStartToFirstContentfulPaintImmediate,
timing.first_contentful_paint - timing.parse_start);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698