Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2158423004: gpu: defer mojo registration and binding resume until full initialization (Closed)

Created:
4 years, 5 months ago by piman
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: defer mojo registration and binding resume until full initialization 1- This makes sure we can send the GpuHostMsg_Initialized message ASAP, since it's in the critical path 2- This makes sure we don't start handling mojo requests if the GPU process is about to exit (dead_on_arrival_ case) 3- This ensures that by construction GpuProcessControlImpl and GpuArcVideoService won't access GpuChildThread before it's initialized 4- This ensures log messages caused by those are not lost BUG=None Committed: https://crrev.com/223a53caf2242c3011ff796aa11a037e3b38824e Cr-Commit-Position: refs/heads/master@{#406761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M content/gpu/gpu_child_thread.cc View 3 chunks +13 lines, -14 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
piman
4 years, 5 months ago (2016-07-21 00:49:29 UTC) #5
Ken Rockot(use gerrit already)
lgtm
4 years, 5 months ago (2016-07-21 00:52:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158423004/1
4 years, 5 months ago (2016-07-21 01:06:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/194190)
4 years, 5 months ago (2016-07-21 01:23:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158423004/1
4 years, 5 months ago (2016-07-21 02:42:37 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 03:42:07 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 03:44:36 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/223a53caf2242c3011ff796aa11a037e3b38824e
Cr-Commit-Position: refs/heads/master@{#406761}

Powered by Google App Engine
This is Rietveld 408576698