Remove content::GpuVideoDecodeAcceleratorFactory

Remove content::GpuVideoDecodeAcceleratorFactory

This can be replaced by media::GpuVideoDecodeAcceleratorFactoryImpl, modulo
properly wiring GpuPreferences.

This in turns allows us to remove GpuChildThread::current() for great justice.

BUG=597150
Committed: https://crrev.com/e785d25b620665c05bfebedbc354b4989ea90ac9
Cr-Commit-Position: refs/heads/master@{#407741}

[piman, 2016-07-21 01:44:55]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 01:45:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-21 01:47:32]

piman@chromium.org changed reviewers:
+ boliu@chromium.org, posciak@chromium.org

[piman, 2016-07-21 01:47:33]

posciak: please review
boliu: android_webview/gpu/aw_content_gpu_client.*

[commit-bot: I haz the power, 2016-07-21 02:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 02:22:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-21 02:52:33]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 02:53:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 04:15:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 04:15:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-21 21:30:58]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 21:32:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 00:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:56:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Pawel Osciak, 2016-07-22 14:34:26]

posciak@chromium.org changed reviewers:
+ kcwu@chromium.org

[Pawel Osciak, 2016-07-22 14:34:27]

Thanks! lgtm in general, just a few nits please

- we have an include rule for gvdaf.h in content/public/gpu/DEPS

- TODO at
https://cs.chromium.org/chromium/src/media/gpu/gpu_video_decode_accelerator_f...
no longer needed

- perhaps we could consider dropping Impl from
GpuVideoDecodeAcceleratorFactoryImpl?


Also +kcwu who knows the Arc service parts best please.

[boliu, 2016-07-22 15:13:22]

lgtm

[piman, 2016-07-22 19:12:38]

The CQ bit was checked by piman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 19:13:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-07-22 19:20:38]

On 2016/07/22 14:34:27, Pawel Osciak wrote:
> Thanks! lgtm in general, just a few nits please
> 
> - we have an include rule for gvdaf.h in content/public/gpu/DEPS

Done.

> 
> - TODO at
>
https://cs.chromium.org/chromium/src/media/gpu/gpu_video_decode_accelerator_f...
> no longer needed

Done.

> 
> - perhaps we could consider dropping Impl from
> GpuVideoDecodeAcceleratorFactoryImpl?

Done in https://codereview.chromium.org/2178603002 so that we can add to
.git-blame-ignore-revs

> 
> 
> Also +kcwu who knows the Arc service parts best please.

[commit-bot: I haz the power, 2016-07-22 21:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 21:53:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[piman, 2016-07-25 20:16:47]

On 2016/07/22 19:20:38, piman - slow reviews until 8-8 wrote:
> On 2016/07/22 14:34:27, Pawel Osciak wrote:
> > Thanks! lgtm in general, just a few nits please
> > 
> > - we have an include rule for gvdaf.h in content/public/gpu/DEPS
> 
> Done.
> 
> > 
> > - TODO at
> >
>
https://cs.chromium.org/chromium/src/media/gpu/gpu_video_decode_accelerator_f...
> > no longer needed
> 
> Done.
> 
> > 
> > - perhaps we could consider dropping Impl from
> > GpuVideoDecodeAcceleratorFactoryImpl?
> 
> Done in https://codereview.chromium.org/2178603002 so that we can add to
> .git-blame-ignore-revs
> 
> > 
> > 
> > Also +kcwu who knows the Arc service parts best please.

@kcwu: ping.

[kcwu, 2016-07-26 03:50:11]

lgtm

[piman, 2016-07-26 05:48:24]

The CQ bit was checked by piman@chromium.org

[piman, 2016-07-26 05:48:25]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
posciak@chromium.org
Link to the patchset: https://codereview.chromium.org/2171473003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-26 05:48:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 09:00:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-26 09:02:30]

Description was changed from

==========
Remove content::GpuVideoDecodeAcceleratorFactory

This can be replaced by media::GpuVideoDecodeAcceleratorFactoryImpl, modulo
properly wiring GpuPreferences.

This in turns allows us to remove GpuChildThread::current() for great justice.

BUG=597150
==========

to

==========
Remove content::GpuVideoDecodeAcceleratorFactory

This can be replaced by media::GpuVideoDecodeAcceleratorFactoryImpl, modulo
properly wiring GpuPreferences.

This in turns allows us to remove GpuChildThread::current() for great justice.

BUG=597150

Committed: https://crrev.com/e785d25b620665c05bfebedbc354b4989ea90ac9
Cr-Commit-Position: refs/heads/master@{#407741}
==========

[commit-bot: I haz the power, 2016-07-26 09:02:30]

Patchset 5 (id:??) landed as
https://crrev.com/e785d25b620665c05bfebedbc354b4989ea90ac9
Cr-Commit-Position: refs/heads/master@{#407741}