Parameters to significantly_different.py need to be parsed as lists.

Parameters to significantly_different.py need to be parsed as lists.

This change addresses a problem with the single-value check that
bypasses MWU. The parameters list_a and list_b are sent to this script
via the command line, and therefore are sent as strings. Before making
the check we need to parse them.

R=eakuefner@chromium.org,dtu@chromium.org
BUG=629261
Committed: https://chromium.googlesource.com/chromium/tools/build/+/20afb69fcdd21aac7c227cdea4799f05af0b9677

[dtu, 2016-07-20 00:08:52]

https://codereview.chromium.org/2158413003/diff/1/scripts/slave/recipe_module...
File
scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py
(right):

https://codereview.chromium.org/2158413003/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py:17:
'first_sample': list_a,
Need it as a python list here as well.

[RobertoCN, 2016-07-20 01:47:50]

Done. Also added tests for that would have caught it.

[RobertoCN, 2016-07-20 01:48:39]

On 2016/07/20 00:08:52, dtu wrote:
>
https://codereview.chromium.org/2158413003/diff/1/scripts/slave/recipe_module...
> File
> scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py
> (right):
> 
>
https://codereview.chromium.org/2158413003/diff/1/scripts/slave/recipe_module...
>
scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py:17:
> 'first_sample': list_a,
> Need it as a python list here as well.

Done.

[RobertoCN, 2016-07-20 01:53:55]

PTAL. Addressed comments.

[dtu, 2016-07-20 16:23:56]

lgtm

[dtu, 2016-07-20 16:23:56]

lgtm

lgtm

[RobertoCN, 2016-07-20 16:43:48]

The CQ bit was checked by robertocn@chromium.org

[commit-bot: I haz the power, 2016-07-20 16:43:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 16:48:10]

Description was changed from

==========
Parameters to significantly_different.py need to be parsed as lists.

This change addresses a problem with the single-value check that
bypasses MWU. The parameters list_a and list_b are sent to this script
via the command line, and therefore are sent as strings. Before making
the check we need to parse them.

R=eakuefner@chromium.org,dtu@chromium.org
BUG=629261
==========

to

==========
Parameters to significantly_different.py need to be parsed as lists.

This change addresses a problem with the single-value check that
bypasses MWU. The parameters list_a and list_b are sent to this script
via the command line, and therefore are sent as strings. Before making
the check we need to parse them.

R=eakuefner@chromium.org,dtu@chromium.org
BUG=629261

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/20afb69fcdd21aac7c22...
==========

[commit-bot: I haz the power, 2016-07-20 16:48:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/20afb69fcdd21aac7c22...