Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py

Issue 2158413003: Parameters to significantly_different.py need to be parsed as lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Addressing feedback. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py b/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py
index 2c8da3cc0c4404c9f442299ebf5a79b39449428e..052ba2d922cc19ecd95136e530797e239a01e5a0 100755
--- a/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py
+++ b/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py
@@ -1,6 +1,7 @@
#!/usr/bin/env python
"""Tests for significantly_different."""
+import json
import os
import sys
import unittest
@@ -22,8 +23,10 @@ class SignificantlyDifferentTest(unittest.TestCase):
def test_basic_case(self):
try:
+ sample_A = [1, 2, 3, 3, 2, 1]
+ sample_B = [1, 2, 2, 2, 5, 0]
results = significantly_different.main(
- ['', '[1, 2, 3, 3, 2, 1]', '[1, 2, 2, 2, 5, 0]', '0.05'],
+ ['', json.dumps(sample_A), json.dumps(sample_B), '0.05'],
self.conda_path)
except significantly_different.ScipyNotInstalledError:
# This is meant to let presubmit pass on CQ bots :( because they don't
@@ -33,6 +36,24 @@ class SignificantlyDifferentTest(unittest.TestCase):
self.assertAlmostEqual(
0.40073980338363635,
results['mann_p_value'])
+ self.assertEqual(results['first_sample'], sample_A)
+ self.assertEqual(results['second_sample'], sample_B)
+
+ def test_single_value(self):
+ try:
+ sample_A = [1, 1, 1, 1, 1, 1]
+ sample_B = [1, 1, 1]
+ results = significantly_different.main(
+ ['', json.dumps(sample_A), json.dumps(sample_B), '0.05'],
+ self.conda_path)
+ except significantly_different.ScipyNotInstalledError:
+ # This is meant to let presubmit pass on CQ bots :( because they don't
+ # have scipy either directly or thorugh anaconda.
+ return
+ self.assertIsNone(results['mann_p_value'])
+ self.assertFalse(results['significantly_different'])
+ self.assertEqual(results['first_sample'], sample_A)
+ self.assertEqual(results['second_sample'], sample_B)
if __name__ == '__main__':
unittest.main()
« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698