scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py - Issue 2158413003: Parameters to significantly_different.py need to be parsed as lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py

Issue 2158413003: Parameters to significantly_different.py need to be parsed as lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Addressing feedback. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py b/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py

index 55b53eb5c1befed463e2e290948afc520cb513dc..77f0bc5bf6c579b151f2e8ec01a296615a82b89b 100644

--- a/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py

+++ b/scripts/slave/recipe_modules/auto_bisect/resources/significantly_different.py

@@ -12,10 +12,10 @@ def main(argv, anaconda_path=None):

_, list_a, list_b, significance = argv

# Do not even test if there's a single repeated value on both samples.

- if len(set(list_a + list_b)) == 1:

+ if len(set(json.loads(list_a) + json.loads(list_b))) == 1:

return {

- 'first_sample': list_a,

- 'second_sample': list_b,

+ 'first_sample': json.loads(list_a),

+ 'second_sample': json.loads(list_b),

'mann_p_value': None,

'anderson_p_value': None,

'welch_p_value': None,

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/resources/significantly_different_test.py » ('j') | no next file with comments »