Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 2158373002: [NTP Snippets] Add a pref to disable the NTPSnippetsService (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add a pref to disable the NTPSnippetsService The new pref isn't used yet. It will be used to implement a policy that disables generated content suggestions. TBRing trivial and analogous iOS change TBR=noyau BUG=595713 Committed: https://crrev.com/2f95b0ea3d0ab826eb1e355b0fbd4618ecbba2aa Cr-Commit-Position: refs/heads/master@{#406279}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -21 lines) Patch
M chrome/browser/ntp_snippets/ntp_snippets_service_factory.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 1 2 chunks +1 line, -3 lines 2 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_status_service.h View 4 chunks +13 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_status_service.cc View 4 chunks +24 lines, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_status_service_unittest.cc View 3 chunks +38 lines, -2 lines 0 comments Download
M components/ntp_snippets/pref_names.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/ntp_snippets/pref_names.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Marc Treib
PTAL! https://codereview.chromium.org/2158373002/diff/20001/components/ntp_snippets/ntp_snippets_service.h File components/ntp_snippets/ntp_snippets_service.h (left): https://codereview.chromium.org/2158373002/diff/20001/components/ntp_snippets/ntp_snippets_service.h#oldcode225 components/ntp_snippets/ntp_snippets_service.h:225: void LoadingSnippetsFinished(); unrelated: no implementation https://codereview.chromium.org/2158373002/diff/20001/components/ntp_snippets/ntp_snippets_service.h#oldcode241 components/ntp_snippets/ntp_snippets_service.h:241: void ...
4 years, 5 months ago (2016-07-19 14:50:57 UTC) #3
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-19 14:56:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158373002/20001
4 years, 5 months ago (2016-07-19 14:58:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 15:31:15 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 15:32:56 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f95b0ea3d0ab826eb1e355b0fbd4618ecbba2aa
Cr-Commit-Position: refs/heads/master@{#406279}

Powered by Google App Engine
This is Rietveld 408576698