Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: components/ntp_snippets/ntp_snippets_service_unittest.cc

Issue 2158373002: [NTP Snippets] Add a pref to disable the NTPSnippetsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/ntp_snippets_service.h" 5 #include "components/ntp_snippets/ntp_snippets_service.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 320
321 // Add an initial fetch response, as the service tries to fetch when there 321 // Add an initial fetch response, as the service tries to fetch when there
322 // is nothing in the DB. 322 // is nothing in the DB.
323 SetUpFetchResponse(GetTestJson({GetSnippet()})); 323 SetUpFetchResponse(GetTestJson({GetSnippet()}));
324 324
325 service_.reset(new NTPSnippetsService( 325 service_.reset(new NTPSnippetsService(
326 enabled, pref_service(), nullptr, "fr", &scheduler_, 326 enabled, pref_service(), nullptr, "fr", &scheduler_,
327 std::move(snippets_fetcher), /*image_fetcher=*/nullptr, 327 std::move(snippets_fetcher), /*image_fetcher=*/nullptr,
328 /*image_fetcher=*/nullptr, base::MakeUnique<NTPSnippetsDatabase>( 328 /*image_fetcher=*/nullptr, base::MakeUnique<NTPSnippetsDatabase>(
329 database_dir_.path(), task_runner), 329 database_dir_.path(), task_runner),
330 base::MakeUnique<NTPSnippetsStatusService>(fake_signin_manager(), 330 base::MakeUnique<NTPSnippetsStatusService>(
331 mock_sync_service()))); 331 fake_signin_manager(), mock_sync_service(), pref_service())));
332 332
333 if (enabled) 333 if (enabled)
334 WaitForDBLoad(service_.get()); 334 WaitForDBLoad(service_.get());
335 } 335 }
336 336
337 protected: 337 protected:
338 const GURL& test_url() { return test_url_; } 338 const GURL& test_url() { return test_url_; }
339 NTPSnippetsService* service() { return service_.get(); } 339 NTPSnippetsService* service() { return service_.get(); }
340 MockScheduler& mock_scheduler() { return scheduler_; } 340 MockScheduler& mock_scheduler() { return scheduler_; }
341 341
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
861 } 861 }
862 862
863 TEST_F(NTPSnippetsServiceTest, HistorySyncStateChanges) { 863 TEST_F(NTPSnippetsServiceTest, HistorySyncStateChanges) {
864 MockServiceObserver mock_observer; 864 MockServiceObserver mock_observer;
865 service()->AddObserver(&mock_observer); 865 service()->AddObserver(&mock_observer);
866 866
867 // Simulate user signed out 867 // Simulate user signed out
868 SetUpFetchResponse(GetTestJson({GetSnippet()})); 868 SetUpFetchResponse(GetTestJson({GetSnippet()}));
869 EXPECT_CALL(mock_observer, NTPSnippetsServiceDisabledReasonChanged( 869 EXPECT_CALL(mock_observer, NTPSnippetsServiceDisabledReasonChanged(
870 DisabledReason::SIGNED_OUT)); 870 DisabledReason::SIGNED_OUT));
871 service()->UpdateStateForStatus(DisabledReason::SIGNED_OUT); 871 service()->OnDisabledReasonChanged(DisabledReason::SIGNED_OUT);
872 base::RunLoop().RunUntilIdle(); 872 base::RunLoop().RunUntilIdle();
873 EXPECT_EQ(NTPSnippetsService::State::DISABLED, service()->state_); 873 EXPECT_EQ(NTPSnippetsService::State::DISABLED, service()->state_);
874 EXPECT_THAT(service()->snippets(), IsEmpty()); // No fetch should be made. 874 EXPECT_THAT(service()->snippets(), IsEmpty()); // No fetch should be made.
875 875
876 // Simulate user sign in. The service should be ready again and load snippets. 876 // Simulate user sign in. The service should be ready again and load snippets.
877 SetUpFetchResponse(GetTestJson({GetSnippet()})); 877 SetUpFetchResponse(GetTestJson({GetSnippet()}));
878 EXPECT_CALL(mock_observer, 878 EXPECT_CALL(mock_observer,
879 NTPSnippetsServiceDisabledReasonChanged(DisabledReason::NONE)); 879 NTPSnippetsServiceDisabledReasonChanged(DisabledReason::NONE));
880 EXPECT_CALL(mock_scheduler(), Schedule(_, _, _, _)).Times(1); 880 EXPECT_CALL(mock_scheduler(), Schedule(_, _, _, _)).Times(1);
881 service()->UpdateStateForStatus(DisabledReason::NONE); 881 service()->OnDisabledReasonChanged(DisabledReason::NONE);
882 base::RunLoop().RunUntilIdle(); 882 base::RunLoop().RunUntilIdle();
883 EXPECT_EQ(NTPSnippetsService::State::READY, service()->state_); 883 EXPECT_EQ(NTPSnippetsService::State::READY, service()->state_);
884 EXPECT_FALSE(service()->snippets().empty()); 884 EXPECT_FALSE(service()->snippets().empty());
885 885
886 service()->RemoveObserver(&mock_observer); 886 service()->RemoveObserver(&mock_observer);
887 } 887 }
888 888
889 } // namespace ntp_snippets 889 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698